Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: content/browser/renderer_host/media/audio_input_renderer_host.cc

Issue 12611030: Remove unused parameter to OnError() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/media/audio_input_renderer_host.h" 5 #include "content/browser/renderer_host/media/audio_input_renderer_host.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/metrics/histogram.h" 8 #include "base/metrics/histogram.h"
9 #include "base/process.h" 9 #include "base/process.h"
10 #include "base/shared_memory.h" 10 #include "base/shared_memory.h"
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 media::AudioInputController* controller) { 86 media::AudioInputController* controller) {
87 BrowserThread::PostTask( 87 BrowserThread::PostTask(
88 BrowserThread::IO, 88 BrowserThread::IO,
89 FROM_HERE, 89 FROM_HERE,
90 base::Bind( 90 base::Bind(
91 &AudioInputRendererHost::DoSendRecordingMessage, 91 &AudioInputRendererHost::DoSendRecordingMessage,
92 this, 92 this,
93 make_scoped_refptr(controller))); 93 make_scoped_refptr(controller)));
94 } 94 }
95 95
96 void AudioInputRendererHost::OnError( 96 void AudioInputRendererHost::OnError(
scherkus (not reviewing) 2013/03/21 17:37:24 nit: this looks like it can fit on one line (i.e.,
jrummell 2013/03/21 18:17:31 Done.
97 media::AudioInputController* controller, 97 media::AudioInputController* controller) {
98 int error_code) {
99 BrowserThread::PostTask( 98 BrowserThread::PostTask(
100 BrowserThread::IO, 99 BrowserThread::IO,
101 FROM_HERE, 100 FROM_HERE,
102 base::Bind(&AudioInputRendererHost::DoHandleError, 101 base::Bind(&AudioInputRendererHost::DoHandleError,
103 this, make_scoped_refptr(controller), error_code)); 102 this, make_scoped_refptr(controller)));
scherkus (not reviewing) 2013/03/21 17:37:24 nit: can you fix indentation here? it should line
jrummell 2013/03/21 18:17:31 Done.
104 } 103 }
105 104
106 void AudioInputRendererHost::OnData(media::AudioInputController* controller, 105 void AudioInputRendererHost::OnData(media::AudioInputController* controller,
107 const uint8* data, 106 const uint8* data,
108 uint32 size) { 107 uint32 size) {
109 NOTREACHED() << "Only low-latency mode is supported."; 108 NOTREACHED() << "Only low-latency mode is supported.";
110 } 109 }
111 110
112 void AudioInputRendererHost::DoCompleteCreation( 111 void AudioInputRendererHost::DoCompleteCreation(
113 media::AudioInputController* controller) { 112 media::AudioInputController* controller) {
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
164 } 163 }
165 164
166 void AudioInputRendererHost::DoSendRecordingMessage( 165 void AudioInputRendererHost::DoSendRecordingMessage(
167 media::AudioInputController* controller) { 166 media::AudioInputController* controller) {
168 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO)); 167 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
169 // TODO(henrika): See crbug.com/115262 for details on why this method 168 // TODO(henrika): See crbug.com/115262 for details on why this method
170 // should be implemented. 169 // should be implemented.
171 } 170 }
172 171
173 void AudioInputRendererHost::DoHandleError( 172 void AudioInputRendererHost::DoHandleError(
174 media::AudioInputController* controller, 173 media::AudioInputController* controller) {
175 int error_code) {
176 DLOG(WARNING) << "AudioInputRendererHost::DoHandleError(error_code="
177 << error_code << ")";
178 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO)); 174 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
179 175
180 AudioEntry* entry = LookupByController(controller); 176 AudioEntry* entry = LookupByController(controller);
181 if (!entry) 177 if (!entry)
182 return; 178 return;
183 179
184 DeleteEntryOnError(entry); 180 DeleteEntryOnError(entry);
185 } 181 }
186 182
187 bool AudioInputRendererHost::OnMessageReceived(const IPC::Message& message, 183 bool AudioInputRendererHost::OnMessageReceived(const IPC::Message& message,
(...skipping 219 matching lines...) Expand 10 before | Expand all | Expand 10 after
407 // TODO(hclam): Implement a faster look up method. 403 // TODO(hclam): Implement a faster look up method.
408 for (AudioEntryMap::iterator i = audio_entries_.begin(); 404 for (AudioEntryMap::iterator i = audio_entries_.begin();
409 i != audio_entries_.end(); ++i) { 405 i != audio_entries_.end(); ++i) {
410 if (controller == i->second->controller.get()) 406 if (controller == i->second->controller.get())
411 return i->second; 407 return i->second;
412 } 408 }
413 return NULL; 409 return NULL;
414 } 410 }
415 411
416 } // namespace content 412 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698