Chromium Code Reviews| Index: src/gpu/GrDefaultGeoProcFactory.h |
| diff --git a/src/gpu/GrDefaultGeoProcFactory.h b/src/gpu/GrDefaultGeoProcFactory.h |
| index bdefd4a920de446148afcbecaa57e8c77f17bd6c..d9f5ca88c4146603e8e4e58bf6fd4eedfc917b7c 100644 |
| --- a/src/gpu/GrDefaultGeoProcFactory.h |
| +++ b/src/gpu/GrDefaultGeoProcFactory.h |
| @@ -127,7 +127,7 @@ namespace GrDefaultGeoProcFactory { |
| const GrGeometryProcessor* Create(const Color&, |
| const Coverage&, |
| const LocalCoords&, |
| - const SkMatrix& viewMatrix = SkMatrix::I()); |
| + const SkMatrix& viewMatrix); |
| /* |
| * Use this factory to create a GrGeometryProcessor that expects a device space vertex position |
| @@ -139,14 +139,15 @@ namespace GrDefaultGeoProcFactory { |
| const LocalCoords&, |
| const SkMatrix& viewMatrix); |
| - // TODO deprecate this |
| - const GrGeometryProcessor* Create(uint32_t gpTypeFlags, |
| - GrColor, |
| - bool localCoordsWillBeRead, |
| - bool coverageWillBeIgnored, |
| - const SkMatrix& viewMatrix = SkMatrix::I(), |
| - const SkMatrix& localMatrix = SkMatrix::I(), |
| - uint8_t coverage = 0xff); |
| + /* |
| + * This factory is for the very specific, but common use case, of drawing in device space but |
| + * also wanting to tweak alpha for coverage if possible. This use case also assumes vertex |
| + * color |
| + */ |
| + const GrGeometryProcessor* CreateForDeviceSpaceAlphaTweakIfPossible(const SkMatrix& viewMatrix, |
|
bsalomon
2015/07/29 19:43:54
Head spinning, what if I set coverageIgnored and t
|
| + bool usesLocalCoords, |
| + bool coverageIgnored, |
| + bool tweakAlphaForCoverage); |
| inline size_t DefaultVertexStride() { return sizeof(PositionAttr); } |
| }; |