Use new API everywhere for GrDefaultGeoProcFactory

src/gpu/GrDefaultGeoProcFactory.h

 /*
  * Copyright 2014 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef GrDefaultGeoProcFactory_DEFINED
 #define GrDefaultGeoProcFactory_DEFINED
 
@@ skipping 109 matching lines @@
         }
         bool hasLocalMatrix() const { return NULL != fMatrix; }
 
         Type fType;
         const SkMatrix* fMatrix;
     };
 
     const GrGeometryProcessor* Create(const Color&,
                                       const Coverage&,
                                       const LocalCoords&,
-                                      const SkMatrix& viewMatrix = SkMatrix::I());
+                                      const SkMatrix& viewMatrix);
 
     /*
      * Use this factory to create a GrGeometryProcessor that expects a device space vertex position
      * attribute. The view matrix must still be provided to compute correctly transformed
      * coordinates for GrFragmentProcessors. It may fail if the view matrix is not invertible.
      */
     const GrGeometryProcessor* CreateForDeviceSpace(const Color&,
                                                     const Coverage&,
                                                     const LocalCoords&,
                                                     const SkMatrix& viewMatrix);
 
-    // TODO deprecate this
-    const GrGeometryProcessor* Create(uint32_t gpTypeFlags,
-                                      GrColor,
-                                      bool localCoordsWillBeRead,
-                                      bool coverageWillBeIgnored,
-                                      const SkMatrix& viewMatrix = SkMatrix::I(),
-                                      const SkMatrix& localMatrix = SkMatrix::I(),
-                                      uint8_t coverage = 0xff);
+    /*
+     * This factory is for the very specific, but common use case, of drawing in device space but
+     * also wanting to tweak alpha for coverage if possible.  This use case also assumes vertex
+     * color
+     */
+    const GrGeometryProcessor* CreateForDeviceSpaceAlphaTweakIfPossible(const SkMatrix& viewMatrix,

[bsalomon, 2015/07/29 19:43:54]

Head spinning, what if I set coverageIgnored and tweakAlphaForCoverage? How do I
know if I have a coverage attribute after this returns?

+                                                                        bool usesLocalCoords,
+                                                                        bool coverageIgnored,
+                                                                        bool tweakAlphaForCoverage);
 
     inline size_t DefaultVertexStride() { return sizeof(PositionAttr); }
 };
 
 #endif