Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1261013003: Move the rest of src headers used by include to include/private. (Closed)

Created:
5 years, 4 months ago by mtklein_C
Modified:
5 years, 4 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move the rest of src headers used by include to include/private. $ git grep "../../src/" | grep include now returns nothing. BUG=skia:4126 No public API changes. TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/d12e6ffa5cc1c1af47bf73c7c127d8d7f7443058

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, -627 lines) Patch
M include/core/SkPictureRecorder.h View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/gl/SkGLContext.h View 2 chunks +2 lines, -2 lines 0 comments Download
A + include/private/SkFunction.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + include/private/SkGpuFenceSync.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + include/private/SkMiniRecorder.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + include/private/SkPathPriv.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + include/private/SkRecords.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M include/views/SkOSWindow_Win.h View 1 chunk +1 line, -1 line 0 comments Download
D src/core/SkFunction.h View 1 chunk +0 lines, -75 lines 0 comments Download
D src/core/SkMiniRecorder.h View 1 chunk +0 lines, -60 lines 0 comments Download
D src/core/SkPathPriv.h View 1 chunk +0 lines, -64 lines 0 comments Download
D src/core/SkRecords.h View 1 chunk +0 lines, -400 lines 1 comment Download
D src/gpu/SkGpuFenceSync.h View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261013003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261013003/1
5 years, 4 months ago (2015-07-28 17:08:43 UTC) #2
mtklein_C
5 years, 4 months ago (2015-07-28 17:09:35 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-28 17:23:37 UTC) #6
bungeman-skia
lgtm
5 years, 4 months ago (2015-07-28 18:41:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261013003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261013003/1
5 years, 4 months ago (2015-07-28 18:51:11 UTC) #9
mtklein_C
Roll's looking good. I'm feeling lucky. Landing now.
5 years, 4 months ago (2015-07-28 18:51:13 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/d12e6ffa5cc1c1af47bf73c7c127d8d7f7443058
5 years, 4 months ago (2015-07-28 18:51:53 UTC) #11
bungeman-skia
https://codereview.chromium.org/1261013003/diff/1/src/core/SkRecords.h File src/core/SkRecords.h (left): https://codereview.chromium.org/1261013003/diff/1/src/core/SkRecords.h#oldcode14 src/core/SkRecords.h:14: #include "SkPathPriv.h" Maybe this is the cause of our ...
5 years, 4 months ago (2015-07-29 14:54:55 UTC) #12
mtklein
On 2015/07/29 14:54:55, bungeman1 wrote: > https://codereview.chromium.org/1261013003/diff/1/src/core/SkRecords.h > File src/core/SkRecords.h (left): > > https://codereview.chromium.org/1261013003/diff/1/src/core/SkRecords.h#oldcode14 > ...
5 years, 4 months ago (2015-07-29 14:55:56 UTC) #13
bungeman-skia
5 years, 4 months ago (2015-07-29 16:58:52 UTC) #14
Message was sent while issue was closed. 
On 2015/07/29 14:55:56, mtklein wrote:
> On 2015/07/29 14:54:55, bungeman1 wrote:
> > https://codereview.chromium.org/1261013003/diff/1/src/core/SkRecords.h
> > File src/core/SkRecords.h (left):
> > 
> >
>
https://codereview.chromium.org/1261013003/diff/1/src/core/SkRecords.h#oldcode14
> > src/core/SkRecords.h:14: #include "SkPathPriv.h"
> > Maybe this is the cause of our ninja problems? Maybe moving a header which
> > includes another moved header can cause issues somehow?
> 
> That sounds plausible.  Let's try landing this CL in dependent layers.

What if we moved everything except SkPathPriv.h and then just moved that
afterword?

Powered by Google App Engine
This is Rietveld 408576698