Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 126093006: [telemetry] Allow public page set data and WPR archives. (Closed)

Created:
6 years, 11 months ago by dtu
Modified:
6 years, 11 months ago
Reviewers:
tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

[telemetry] Allow public page set data and WPR archives. BUG=332148 TEST=mv ~/.boto ~/.boto.bak; rm tools/perf/page_sets/data/key_silk_cases_000.wpr; tools/perf/run_benchmark silk.key_silk_cases -v; mv ~/.boto.bak ~/.boto Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243447

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -39 lines) Patch
M tools/perf/page_sets/PRESUBMIT.py View 4 chunks +52 lines, -11 lines 0 comments Download
D tools/perf/page_sets/data/test.json View 1 chunk +0 lines, -8 lines 0 comments Download
D tools/perf/page_sets/data/test_000.wpr.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/linux_platform_backend.py View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/android_prebuilt_profiler_helper.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/cloud_storage.py View 3 chunks +20 lines, -10 lines 0 comments Download
M tools/telemetry/telemetry/page/page_set.py View 2 chunks +1 line, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/page_set_archive_info.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
dtu
6 years, 11 months ago (2014-01-07 20:22:51 UTC) #1
tonyg
lgtm
6 years, 11 months ago (2014-01-07 21:17:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/126093006/1
6 years, 11 months ago (2014-01-07 21:49:49 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 00:34:45 UTC) #4
Message was sent while issue was closed.
Change committed as 243447

Powered by Google App Engine
This is Rietveld 408576698