tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py - Issue 126093006: [telemetry] Allow public page set data and WPR archives.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py

Issue 126093006: [telemetry] Allow public page set data and WPR archives. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/perf/page_sets/data/test_000.wpr.sha1 ('k') | tools/telemetry/telemetry/core/platform/linux_platform_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py

diff --git a/tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py b/tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py

index 40bfd0d03cd45ddb70ef219b4de78172f22d0579..05f3c0908ffea7f65a7ff0bb54ae37aca2c817e9 100644

--- a/tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py

+++ b/tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py

@@ -73,7 +73,7 @@ class PossibleDesktopIE(PossibleWebDriverBrowser):

def DriverCreator():

ie_driver_exe = os.path.join(util.GetTelemetryDir(), 'bin',

'IEDriverServer_%s.exe' % self._architecture)

- cloud_storage.GetIfChanged(cloud_storage.PUBLIC_BUCKET, ie_driver_exe)

+ cloud_storage.GetIfChanged(ie_driver_exe, cloud_storage.PUBLIC_BUCKET)

return webdriver.Ie(executable_path=ie_driver_exe)

return webdriver_ie_backend.WebDriverIEBackend(

platform_backend, DriverCreator, self.finder_options.browser_options)

« no previous file with comments | « tools/perf/page_sets/data/test_000.wpr.sha1 ('k') | tools/telemetry/telemetry/core/platform/linux_platform_backend.py » ('j') | no next file with comments »