Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1383)

Issue 1260733003: [turbofan] Merge dependent Word32Equal on ARM64 (Closed)

Created:
5 years, 4 months ago by martyn.capewell
Modified:
5 years, 4 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Merge dependent Word32Equal on ARM64 Improve code generated for flag materialization. Committed: https://crrev.com/9bf532350f1f2f55a215a998114cd97fe7d7b190 Cr-Commit-Position: refs/heads/master@{#29954}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
martyn.capewell
5 years, 4 months ago (2015-07-29 16:24:45 UTC) #2
Benedikt Meurer
lgtm
5 years, 4 months ago (2015-07-30 06:29:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260733003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260733003/1
5 years, 4 months ago (2015-07-30 08:52:31 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/6573)
5 years, 4 months ago (2015-07-30 09:19:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260733003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260733003/1
5 years, 4 months ago (2015-07-31 12:25:43 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-31 12:46:04 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 12:46:20 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9bf532350f1f2f55a215a998114cd97fe7d7b190
Cr-Commit-Position: refs/heads/master@{#29954}

Powered by Google App Engine
This is Rietveld 408576698