Issue 126073002: [#1] Pass gfx structs by const ref (presubmit check)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 126073002: [#1] Pass gfx structs by const ref (presubmit check) (Closed)

Created:
6 years, 11 months ago by prashant.n

Modified:
6 years, 11 months ago

Reviewers:
danakj, enne (OOO)

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Remove presubmit checks from cc/PRESUBMIT.py which checked gfx structs by value. Subsequent patches will clean up all the gfx structs to be passed by ref. BUG=159273 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243415

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -7 lines)			Patch
	M	cc/PRESUBMIT.py	View		1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/prashant.n@samsung.com/126073002/1

6 years, 11 months ago (2014-01-07 17:28:51 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242585

6 years, 11 months ago (2014-01-07 19:57:13 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/prashant.n@samsung.com/126073002/1

6 years, 11 months ago (2014-01-07 20:01:05 UTC) #5

Message was sent while issue was closed.

Change committed as 243415

Expand Messages | Collapse Messages