cc/PRESUBMIT.py - Issue 126073002: [#1] Pass gfx structs by const ref (presubmit check)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/PRESUBMIT.py

Issue 126073002: [#1] Pass gfx structs by const ref (presubmit check) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/PRESUBMIT.py

diff --git a/cc/PRESUBMIT.py b/cc/PRESUBMIT.py

index 5b8100b82667cca5331a6dc86240d93715fa3282..2dd1998996b644474d07cacf9cee27716b5a44cb 100644

--- a/cc/PRESUBMIT.py

+++ b/cc/PRESUBMIT.py

@@ -116,13 +116,6 @@ def CheckPassByValue(input_api,

# Well-defined simple classes containing only <= 4 ints, or <= 2 floats.

pass_by_value_types = ['base::Time',

'base::TimeTicks',

- 'gfx::Point',

- 'gfx::PointF',

- 'gfx::Rect',

- 'gfx::Size',

- 'gfx::SizeF',

- 'gfx::Vector2d',

- 'gfx::Vector2dF',

]

for f in input_api.AffectedSourceFiles(source_file_filter):

« no previous file with comments | « no previous file | no next file » | no next file with comments »