Fix a crashing call to GURL::spec() in downloads_api.cc:DownloadItemToJSON()

chrome/browser/safe_browsing/ping_manager.cc

Index: chrome/browser/safe_browsing/ping_manager.cc
diff --git a/chrome/browser/safe_browsing/ping_manager.cc b/chrome/browser/safe_browsing/ping_manager.cc
index 6e739857ab7606290f8ebffb3c22a02e46b42321..a72c1aa0468be9ff9eb82a7c6209be3de146df88 100644
--- a/chrome/browser/safe_browsing/ping_manager.cc
+++ b/chrome/browser/safe_browsing/ping_manager.cc
@@ -134,11 +134,17 @@ GURL SafeBrowsingPingManager::SafeBrowsingHitUrl(
     default:
       NOTREACHED();
   }
+  const std::string& malicious_str = malicious_url.is_valid() ?
+    malicious_url.spec() : "";
+  const std::string& page_str = page_url.is_valid() ?
+    page_url.spec() : "";
+  const std::string& referrer_str = referrer_url.is_valid() ?
+    referrer_url.spec() : "";

[Scott Hess - ex-Googler, 2013/03/14 17:46:51]

What does it mean to have a threat-hit but empty URLs for this?  It looks like
the "none" case is expected to never happen, so I think it means that this fix
will pollute someone's reporting.

   return GURL(base::StringPrintf("%s&evts=%s&evtd=%s&evtr=%s&evhr=%s&evtb=%d",
       url.c_str(), threat_list.c_str(),
-      net::EscapeQueryParamValue(malicious_url.spec(), true).c_str(),
-      net::EscapeQueryParamValue(page_url.spec(), true).c_str(),
-      net::EscapeQueryParamValue(referrer_url.spec(), true).c_str(),
+      net::EscapeQueryParamValue(malicious_str, true).c_str(),
+      net::EscapeQueryParamValue(page_str, true).c_str(),
+      net::EscapeQueryParamValue(referrer_str, true).c_str(),
       is_subresource));
 }