Fix a crashing call to GURL::spec() in downloads_api.cc:DownloadItemToJSON()

chrome/browser/safe_browsing/ping_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/safe_browsing/ping_manager.h"
 
 #include "base/logging.h"
 #include "base/stl_util.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
@@ skipping 116 matching lines @@
       break;
     case SB_THREAT_TYPE_BINARY_MALWARE_HASH:
       threat_list = "binhashhit";
       break;
     case SB_THREAT_TYPE_CLIENT_SIDE_PHISHING_URL:
       threat_list = "phishcsdhit";
       break;
     default:
       NOTREACHED();
   }
+  const std::string& malicious_str = malicious_url.is_valid() ?
+    malicious_url.spec() : "";
+  const std::string& page_str = page_url.is_valid() ?
+    page_url.spec() : "";
+  const std::string& referrer_str = referrer_url.is_valid() ?
+    referrer_url.spec() : "";

[Scott Hess - ex-Googler, 2013/03/14 17:46:51]

What does it mean to have a threat-hit but empty URLs for this?  It looks like
the "none" case is expected to never happen, so I think it means that this fix
will pollute someone's reporting.

   return GURL(base::StringPrintf("%s&evts=%s&evtd=%s&evtr=%s&evhr=%s&evtb=%d",
       url.c_str(), threat_list.c_str(),
-      net::EscapeQueryParamValue(malicious_url.spec(), true).c_str(),
-      net::EscapeQueryParamValue(page_url.spec(), true).c_str(),
-      net::EscapeQueryParamValue(referrer_url.spec(), true).c_str(),
+      net::EscapeQueryParamValue(malicious_str, true).c_str(),
+      net::EscapeQueryParamValue(page_str, true).c_str(),
+      net::EscapeQueryParamValue(referrer_str, true).c_str(),
       is_subresource));
 }
 
 GURL SafeBrowsingPingManager::MalwareDetailsUrl() const {
   std::string url = base::StringPrintf(
           "%s/clientreport/malware?client=%s&appver=%s&pver=1.0",
           url_prefix_.c_str(),
           client_name_.c_str(),
           version_.c_str());
   std::string api_key = google_apis::GetAPIKey();
   if (!api_key.empty()) {
     base::StringAppendF(&url, "&key=%s",
                         net::EscapeQueryParamValue(api_key, true).c_str());
   }
   return GURL(url);
 }