Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 1260693003: Add eventSender support for web pointer properties in touch points. (Closed)

Created:
5 years, 4 months ago by USE eero AT chromium.org
Modified:
5 years, 4 months ago
Reviewers:
mustaq, Rick Byers
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add eventSender support for web pointer properties in touch points. This support is needed for web pointer property propagation layout tests. This CL is a part of a patch series: 1. https://codereview.chromium.org/1253183005/ for new WebPointerProperties fields 2. https://codereview.chromium.org/1260693003/ (this) 3a. https://codereview.chromium.org/1192563002/ for handling tilt in Blink event handlers 3b. https://codereview.chromium.org/1192463008/ for handling pointer type in Blink event handlers 4a. https://codereview.chromium.org/1187273004/ for handling tilt in Chromium event handlers 4b. https://codereview.chromium.org/1190013002/ for handling pointer type in Chromium event handlers BUG=514360 Committed: https://crrev.com/80033921f398c8efe7d751182d2d87f8583e9ba1 Cr-Commit-Position: refs/heads/master@{#341299}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Added TODO comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -38 lines) Patch
M components/test_runner/event_sender.h View 3 chunks +6 lines, -2 lines 0 comments Download
M components/test_runner/event_sender.cc View 1 9 chunks +100 lines, -36 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
USE eero AT chromium.org
Created based on https://codereview.chromium.org/1192563002/#msg12 I have to create a layout test for checking that this ...
5 years, 4 months ago (2015-07-27 17:59:33 UTC) #2
Rick Byers
Seems reasonable to me (the very long list of args may get a little tedius/brittle, ...
5 years, 4 months ago (2015-07-27 20:57:37 UTC) #3
mustaq
https://codereview.chromium.org/1260693003/diff/1/components/test_runner/event_sender.cc File components/test_runner/event_sender.cc (right): https://codereview.chromium.org/1260693003/diff/1/components/test_runner/event_sender.cc#newcode1758 components/test_runner/event_sender.cc:1758: if (touch_points_[i].id == lowest_id) This is not your code, ...
5 years, 4 months ago (2015-07-29 17:11:34 UTC) #5
USE eero AT chromium.org
https://codereview.chromium.org/1260693003/diff/1/components/test_runner/event_sender.cc File components/test_runner/event_sender.cc (right): https://codereview.chromium.org/1260693003/diff/1/components/test_runner/event_sender.cc#newcode1758 components/test_runner/event_sender.cc:1758: if (touch_points_[i].id == lowest_id) On 2015/07/29 17:11:34, mustaq wrote: ...
5 years, 4 months ago (2015-07-29 17:39:37 UTC) #6
Rick Byers
LGTM. Thanks for kicking of linux_blink_rel, good to see it's green. I kicked off a ...
5 years, 4 months ago (2015-07-30 17:44:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260693003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260693003/20001
5 years, 4 months ago (2015-07-31 08:07:01 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-07-31 08:41:49 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 08:42:40 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/80033921f398c8efe7d751182d2d87f8583e9ba1
Cr-Commit-Position: refs/heads/master@{#341299}

Powered by Google App Engine
This is Rietveld 408576698