SkScaledCodec class

include/codec/SkCodec.h

Index: include/codec/SkCodec.h
diff --git a/include/codec/SkCodec.h b/include/codec/SkCodec.h
index 1cdc88d4adcfc0dc4e028913348dd21c287e50e7..60045bdf6dfdad07a7e3c159bb989fb106a47b86 100644
--- a/include/codec/SkCodec.h
+++ b/include/codec/SkCodec.h
@@ -52,6 +52,8 @@ public:
      *  Return a size that approximately supports the desired scale factor.
      *  The codec may not be able to scale efficiently to the exact scale
      *  factor requested, so return a size that approximates that scale.
+     *  This is a suggestion to the user. The dimensions getScanlineDecoder

[scroggo, 2015/07/30 17:53:01]

The first sentence sounds good. For the second, I am not really sure what you're
trying to communicate. The user is going to call getScanlineDecoder, and they're
in control of the dimensions they use. Are you trying to state that they do not
have to use these dimensions?

[emmaleer, 2015/07/30 22:27:55]

Yes that's what I was trying to say. I think mentioning that the dimensions are
a suggestion states that already though. 

+     *  is called with may not be the same.
      */
     SkISize getScaledDimensions(float desiredScale) const {
         return this->onGetScaledDimensions(desiredScale);
@@ -72,6 +74,7 @@ public:
      *  @return true if this codec supports decoding desiredSubset (as
      *      returned, potentially modified)
      */
+

[msarett, 2015/07/30 13:55:38]

nit: I don't think we want this new line.

[emmaleer, 2015/07/30 17:50:39]

Acknowledged.

[scroggo, 2015/07/30 17:53:01]

nit: This extra line is not needed.

     bool getValidSubset(SkIRect* desiredSubset) const {
         return this->onGetValidSubset(desiredSubset);
     }