SkScaledCodec class

include/codec/SkCodec.h

 /*
  * Copyright 2015 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef SkCodec_DEFINED
 #define SkCodec_DEFINED
 
@@ skipping 34 matching lines @@
 
     /**
      *  Return the ImageInfo associated with this codec.
      */
     const SkImageInfo& getInfo() const { return fInfo; }
 
     /**
      *  Return a size that approximately supports the desired scale factor.
      *  The codec may not be able to scale efficiently to the exact scale
      *  factor requested, so return a size that approximates that scale.
+     *  This is a suggestion to the user. The dimensions getScanlineDecoder

[scroggo, 2015/07/30 17:53:01]

The first sentence sounds good. For the second, I am not really sure what you're
trying to communicate. The user is going to call getScanlineDecoder, and they're
in control of the dimensions they use. Are you trying to state that they do not
have to use these dimensions?

[emmaleer, 2015/07/30 22:27:55]

Yes that's what I was trying to say. I think mentioning that the dimensions are
a suggestion states that already though. 

+     *  is called with may not be the same.
      */
     SkISize getScaledDimensions(float desiredScale) const {
         return this->onGetScaledDimensions(desiredScale);
     }
 
     /**
      *  Return (via desiredSubset) a subset which can decoded from this codec,
      *  or false if this codec cannot decode subsets or anything similar to
      *  desiredSubset.
      *
      *  @param desiredSubset In/out parameter. As input, a desired subset of
      *      the original bounds (as specified by getInfo). If true is returned,
      *      desiredSubset may have been modified to a subset which is
      *      supported. Although a particular change may have been made to
      *      desiredSubset to create something supported, it is possible other
      *      changes could result in a valid subset.
      *      If false is returned, desiredSubset's value is undefined.
      *  @return true if this codec supports decoding desiredSubset (as
      *      returned, potentially modified)
      */
+

[msarett, 2015/07/30 13:55:38]

nit: I don't think we want this new line.

[emmaleer, 2015/07/30 17:50:39]

Acknowledged.

[scroggo, 2015/07/30 17:53:01]

nit: This extra line is not needed.

     bool getValidSubset(SkIRect* desiredSubset) const {
         return this->onGetValidSubset(desiredSubset);
     }
 
     /**
      *  Format of the encoded data.
      */
     SkEncodedFormat getEncodedFormat() const { return this->onGetEncodedFormat(); }
 
     /**
@@ skipping 231 matching lines @@
     SkStream* stream() {
         return fStream.get();
     }
 
 private:
     const SkImageInfo       fInfo;
     SkAutoTDelete<SkStream> fStream;
     bool                    fNeedsRewind;
 };
 #endif // SkCodec_DEFINED