Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12605011: Revert 188912 "Removed static factories for data, ftp, file, and..." (Closed)

Created:
7 years, 9 months ago by Ken Russell (switch to Gerrit)
Modified:
7 years, 9 months ago
Reviewers:
pauljensen
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 188912 "Removed static factories for data, ftp, file, and..." Broke layout tests userscripts/user-script-plugin-document.html and plugins/plugin-document-back-forward.html on all platforms. > Removed static factories for data, ftp, file, and about jobs. > Instead add corresponding ProtocolHandlers as needed. > Remove URLRequestContext members used by these static > factories. Bake FtpAuthCache into FtpProtocolHandler as it > was already unique per FtpProtocolHandler. > This is a revived version of http://crrev.com/10836206 > > BUG=142945 > > > Review URL: https://chromiumcodereview.appspot.com/11931024 TBR=pauljensen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188927

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -299 lines) Patch
M trunk/src/android_webview/browser/net/aw_url_request_context_getter.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/android_webview/browser/net/aw_url_request_job_factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/android_webview/browser/net/aw_url_request_job_factory.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/custom_handlers/protocol_handler_registry.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/custom_handlers/protocol_handler_registry.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc View 4 chunks +0 lines, -9 lines 0 comments Download
M trunk/src/chrome/browser/io_thread.h View 2 chunks +3 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/io_thread.cc View 5 chunks +9 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/net/about_protocol_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/net/about_protocol_handler.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/net/connection_tester.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/profiles/off_the_record_profile_io_data.h View 1 chunk +0 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/profiles/off_the_record_profile_io_data.cc View 5 chunks +12 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/profiles/profile_impl_io_data.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/profiles/profile_impl_io_data.cc View 5 chunks +12 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/profiles/profile_io_data.h View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/profiles/profile_io_data.cc View 3 chunks +7 lines, -10 lines 0 comments Download
M trunk/src/chrome/service/net/service_url_request_context.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M trunk/src/content/browser/browser_plugin/browser_plugin_host_browsertest.cc View 2 chunks +1 line, -8 lines 0 comments Download
M trunk/src/content/browser/child_process_security_policy_unittest.cc View 1 chunk +1 line, -7 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_view_host_unittest.cc View 2 chunks +0 lines, -35 lines 0 comments Download
M trunk/src/content/browser/webui/url_data_manager_backend.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/content/shell/shell_content_browser_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/content/shell/shell_content_browser_client.cc View 2 chunks +0 lines, -22 lines 0 comments Download
M trunk/src/content/shell/shell_url_request_context_getter.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M trunk/src/net/ftp/ftp_network_session.h View 3 chunks +3 lines, -0 lines 0 comments Download
M trunk/src/net/proxy/proxy_script_fetcher_impl_unittest.cc View 2 chunks +1 line, -4 lines 0 comments Download
M trunk/src/net/url_request/file_protocol_handler.h View 2 chunks +0 lines, -3 lines 0 comments Download
M trunk/src/net/url_request/file_protocol_handler.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/net/url_request/ftp_protocol_handler.h View 2 chunks +4 lines, -3 lines 0 comments Download
M trunk/src/net/url_request/ftp_protocol_handler.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M trunk/src/net/url_request/protocol_intercept_job_factory.h View 2 chunks +0 lines, -3 lines 0 comments Download
M trunk/src/net/url_request/protocol_intercept_job_factory.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M trunk/src/net/url_request/url_request_about_job.h View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/net/url_request/url_request_about_job.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M trunk/src/net/url_request/url_request_context.h View 5 chunks +23 lines, -0 lines 0 comments Download
M trunk/src/net/url_request/url_request_context.cc View 3 chunks +7 lines, -0 lines 0 comments Download
M trunk/src/net/url_request/url_request_context_builder.h View 4 chunks +1 line, -22 lines 0 comments Download
M trunk/src/net/url_request/url_request_context_builder.cc View 4 chunks +6 lines, -24 lines 0 comments Download
M trunk/src/net/url_request/url_request_context_storage.h View 2 chunks +3 lines, -0 lines 0 comments Download
M trunk/src/net/url_request/url_request_context_storage.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M trunk/src/net/url_request/url_request_data_job.h View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/net/url_request/url_request_data_job.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M trunk/src/net/url_request/url_request_file_job.h View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/net/url_request/url_request_file_job.cc View 1 chunk +28 lines, -0 lines 0 comments Download
M trunk/src/net/url_request/url_request_ftp_job.h View 1 chunk +5 lines, -0 lines 0 comments Download
M trunk/src/net/url_request/url_request_ftp_job.cc View 2 chunks +20 lines, -1 line 0 comments Download
M trunk/src/net/url_request/url_request_ftp_job_unittest.cc View 4 chunks +2 lines, -18 lines 0 comments Download
M trunk/src/net/url_request/url_request_http_job.cc View 2 chunks +17 lines, -9 lines 0 comments Download
M trunk/src/net/url_request/url_request_job_factory.h View 2 chunks +0 lines, -9 lines 0 comments Download
M trunk/src/net/url_request/url_request_job_factory.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M trunk/src/net/url_request/url_request_job_factory_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/net/url_request/url_request_job_factory_impl.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M trunk/src/net/url_request/url_request_job_manager.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M trunk/src/net/url_request/url_request_test_util.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M trunk/src/net/url_request/url_request_unittest.cc View 5 chunks +9 lines, -23 lines 0 comments Download
M trunk/src/webkit/tools/test_shell/test_shell_request_context.cc View 4 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ken Russell (switch to Gerrit)
7 years, 9 months ago (2013-03-19 03:05:27 UTC) #1
Ken Russell (switch to Gerrit)
7 years, 9 months ago (2013-03-19 03:05:54 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r188927.

Powered by Google App Engine
This is Rietveld 408576698