Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Unified Diff: trunk/src/chrome/browser/profiles/off_the_record_profile_io_data.cc

Issue 12605011: Revert 188912 "Removed static factories for data, ftp, file, and..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/profiles/off_the_record_profile_io_data.cc
===================================================================
--- trunk/src/chrome/browser/profiles/off_the_record_profile_io_data.cc (revision 188924)
+++ trunk/src/chrome/browser/profiles/off_the_record_profile_io_data.cc (working copy)
@@ -216,6 +216,7 @@
#if !defined(DISABLE_FTP_SUPPORT)
ftp_factory_.reset(
new net::FtpNetworkLayer(main_context->host_resolver()));
+ main_context->set_ftp_transaction_factory(ftp_factory_.get());
#endif // !defined(DISABLE_FTP_SUPPORT)
scoped_ptr<net::URLRequestJobFactoryImpl> main_job_factory(
@@ -226,7 +227,8 @@
main_job_factory.Pass(),
profile_params->protocol_handler_interceptor.Pass(),
network_delegate(),
- ftp_factory_.get());
+ main_context->ftp_transaction_factory(),
+ main_context->ftp_auth_cache());
main_context->set_job_factory(main_job_factory_.get());
#if defined(ENABLE_EXTENSIONS)
@@ -260,6 +262,11 @@
extensions_cookie_store->SetCookieableSchemes(schemes, 2);
extensions_context->set_cookie_store(extensions_cookie_store);
+#if !defined(DISABLE_FTP_SUPPORT)
+ DCHECK(ftp_factory_.get());
+ extensions_context->set_ftp_transaction_factory(ftp_factory_.get());
+#endif // !defined(DISABLE_FTP_SUPPORT)
+
scoped_ptr<net::URLRequestJobFactoryImpl> extensions_job_factory(
new net::URLRequestJobFactoryImpl());
// TODO(shalev): The extensions_job_factory has a NULL NetworkDelegate.
@@ -272,7 +279,8 @@
extensions_job_factory.Pass(),
scoped_ptr<ProtocolHandlerRegistry::JobInterceptorFactory>(NULL),
NULL,
- ftp_factory_.get());
+ extensions_context->ftp_transaction_factory(),
+ extensions_context->ftp_auth_cache());
extensions_context->set_job_factory(extensions_job_factory_.get());
}
@@ -310,7 +318,8 @@
top_job_factory = SetUpJobFactoryDefaults(job_factory.Pass(),
protocol_handler_interceptor.Pass(),
network_delegate(),
- ftp_factory_.get());
+ context->ftp_transaction_factory(),
+ context->ftp_auth_cache());
context->SetJobFactory(top_job_factory.Pass());
return context;
}

Powered by Google App Engine
This is Rietveld 408576698