Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1260453008: Remove SK_BUILD_FOR_WINCE. (Closed)

Created:
5 years, 4 months ago by bungeman-skia
Modified:
5 years, 4 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove SK_BUILD_FOR_WINCE. This hasn't been tested for years, and no one currently knows when it last worked (if ever). It is doubtful that any of the remaining logic would even make sense with a modern version of Embedded Compact 2013. Committed: https://skia.googlesource.com/skia/+/028205bedb7df56b0995ebb44238a69ff1681d0b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -68 lines) Patch
M include/core/SkFloatingPoint.h View 1 chunk +15 lines, -31 lines 0 comments Download
M include/core/SkPreConfig.h View 2 chunks +1 line, -3 lines 0 comments Download
M include/views/SkWindow.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/views/SkWindow.cpp View 3 chunks +0 lines, -29 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260453008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260453008/1
5 years, 4 months ago (2015-07-29 19:25:24 UTC) #2
bungeman-skia
5 years, 4 months ago (2015-07-29 19:25:45 UTC) #4
reed1
death to you all lgtm
5 years, 4 months ago (2015-07-29 19:28:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260453008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260453008/1
5 years, 4 months ago (2015-07-29 19:33:59 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-07-29 19:34:30 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/028205bedb7df56b0995ebb44238a69ff1681d0b

Powered by Google App Engine
This is Rietveld 408576698