Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: content/common/child_process_host_impl.h

Issue 126033004: Clean up ChildProcessHost unique id generation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: start from 1 Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/child_process_host_impl.h
diff --git a/content/common/child_process_host_impl.h b/content/common/child_process_host_impl.h
index e0e4bbf39d61383c750c126601e2d32ebd4317f9..470fa0efab47260e887b9c5c4b9cd91b245bcf1f 100644
--- a/content/common/child_process_host_impl.h
+++ b/content/common/child_process_host_impl.h
@@ -37,10 +37,6 @@ class CONTENT_EXPORT ChildProcessHostImpl : public ChildProcessHost,
public:
virtual ~ChildProcessHostImpl();
- // This value is guaranteed to never be returned by
- // GenerateChildProcessUniqueId() below.
- static int kInvalidChildProcessId;
-
// Public and static for reuse by RenderMessageFilter.
static void AllocateSharedMemory(
size_t buffer_size, base::ProcessHandle child_process,
@@ -53,6 +49,8 @@ class CONTENT_EXPORT ChildProcessHostImpl : public ChildProcessHost,
//
// This function is threadsafe since RenderProcessHost is on the UI thread,
// but normally this will be used on the IO thread.
+ //
+ // This will never return ChildProcessHost::kInvalidChildProcessUniqueId.
static int GenerateChildProcessUniqueId();
// ChildProcessHost implementation

Powered by Google App Engine
This is Rietveld 408576698