Clean up ChildProcessHost unique id generation.

content/public/common/child_process_host.h

Index: content/public/common/child_process_host.h
diff --git a/content/public/common/child_process_host.h b/content/public/common/child_process_host.h
index bccbd67b89d8d1683d0f80653b318e10e1ac4236..fb65289c3ba89825ff7836b29338d9064fe1b97f 100644
--- a/content/public/common/child_process_host.h
+++ b/content/public/common/child_process_host.h
@@ -24,9 +24,12 @@ class CONTENT_EXPORT ChildProcessHost : public IPC::Sender {
  public:
   virtual ~ChildProcessHost() {}
 
+  // This is a value never returned as the unique id of any child processes of
+  // any kind, including the values returned by RenderProcessHost::GetID().
+  static int kInvalidChildProcessUniqueId;

[jam, 2014/01/07 21:05:01]

nit: ChildProcessHost::kInvalidChildProcessUniqueId seems redundant. how about
ChildProcessHost::kInvalidID?

[Avi (use Gerrit), 2014/01/07 21:47:47]

Done.

[Avi (use Gerrit), 2014/01/08 16:25:45]

No, sorry. kInvalidID is used in the Mac headers as a macro, and I can't
undefine it because it's used to define other constants.

Argh.

How about kInvalidUniqueID?

+
   // Used to create a child process host. The delegate must outlive this object.
-  static ChildProcessHost* Create(
-      ChildProcessHostDelegate* delegate);
+  static ChildProcessHost* Create(ChildProcessHostDelegate* delegate);
 
   // These flags may be passed to GetChildPath in order to alter its behavior,
   // causing it to return a child path more suited to a specific task.