Issue 126028: Remove a DCHECK which is being hit because of a unit-test's particular setup....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 126028: Remove a DCHECK which is being hit because of a unit-test's particular setup.... (Closed)

Created:
11 years, 6 months ago by eroman

Modified:
9 years, 6 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Remove a DCHECK which is being hit because of a unit-test's particular setup. TBR=willchan Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18240

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	net/base/host_resolver.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

eroman

The problem here is the DCHECK() should be done AFTER the check for was_cancelled(). Since ...

11 years, 6 months ago (2009-06-12 01:25:56 UTC) #1

lgtm