net/base/host_resolver.cc - Issue 126028: Remove a DCHECK which is being hit because of a unit-test's particular setup....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/host_resolver.cc

Issue 126028: Remove a DCHECK which is being hit because of a unit-test's particular setup.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 11 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/base/host_resolver.cc

===================================================================

--- net/base/host_resolver.cc (revision 18236)

+++ net/base/host_resolver.cc (working copy)

@@ -320,7 +320,10 @@

// Callback for when DoLookup() completes (runs on origin thread).

void OnLookupComplete() {

- DCHECK_EQ(origin_loop_, MessageLoop::current());

+ // Should be running on origin loop.

+ // TODO(eroman): this is being hit by URLRequestTest.CancelTest*,

+ // because MessageLoop::current() == NULL.

+ //DCHECK_EQ(origin_loop_, MessageLoop::current());

DCHECK(error_ || results_);

if (was_cancelled())

« no previous file with comments | « no previous file | no next file » | no next file with comments »