Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Issue 126013002: [Telemetry]: Move assert on page measurement results name into Value object. (Closed)

Created:
6 years, 11 months ago by rmcilroy
Modified:
6 years, 11 months ago
Reviewers:
tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org, nduca
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Telemetry]: Move assert on page measurement results name into Value object. The use of a '.' in a trace name only breaks the telemetry value result if it occurs in a value which does not have a trace_name. This CL moves the assert into the Value object so that the assert doesn't fire in other situations (such as the media.tough_media_cases benchmark), where the use of the '.' is actually ok. BUG=332041, 329845 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243441

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/telemetry/telemetry/page/page_measurement_results.py View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/value/__init__.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
rmcilroy
Turns out the previous CL broke media.tough_media_case. This fixes it, without having to change the ...
6 years, 11 months ago (2014-01-07 14:11:59 UTC) #1
tonyg
lgtm
6 years, 11 months ago (2014-01-07 17:00:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/126013002/1
6 years, 11 months ago (2014-01-07 17:18:10 UTC) #3
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=208536
6 years, 11 months ago (2014-01-07 17:38:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/126013002/1
6 years, 11 months ago (2014-01-07 17:40:19 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242686
6 years, 11 months ago (2014-01-07 22:35:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/126013002/1
6 years, 11 months ago (2014-01-07 23:10:02 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 00:10:55 UTC) #8
Message was sent while issue was closed.
Change committed as 243441

Powered by Google App Engine
This is Rietveld 408576698