Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: tools/telemetry/telemetry/value/__init__.py

Issue 126013002: [Telemetry]: Move assert on page measurement results name into Value object. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/page/page_measurement_results.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/value/__init__.py
diff --git a/tools/telemetry/telemetry/value/__init__.py b/tools/telemetry/telemetry/value/__init__.py
index 6148832b1414ef21c9d84feb02f71851636d1b6a..991b2492c0f7e68cf5483afc97320990409c258a 100644
--- a/tools/telemetry/telemetry/value/__init__.py
+++ b/tools/telemetry/telemetry/value/__init__.py
@@ -164,6 +164,8 @@ def ValueNameFromTraceAndChartName(trace_name, chart_name=None):
if chart_name:
return '%s.%s' % (chart_name, trace_name)
else:
+ assert '.' not in trace_name, ('Trace names cannot contain "." with an '
+ 'empty chart_name since this is used to delimit chart_name.trace_name.')
return trace_name
def _ConvertValueNameToBuildbotChartAndTraceName(value_name):
« no previous file with comments | « tools/telemetry/telemetry/page/page_measurement_results.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698