chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc - Issue 1260033003: Partially componentize //chrome/browser/search/search.{h,cc}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc

Issue 1260033003: Partially componentize //chrome/browser/search/search.{h,cc} (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix compilation on iOS Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc

diff --git a/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc b/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc

index 65c5ce9527bc28c87179bb232055f224683654d8..1ef70ed84150159db047df7390d5305035dd5d63 100644

--- a/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc

+++ b/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc

@@ -493,7 +493,7 @@ void RecentTabsSubMenuModel::BuildTabsFromOtherDevices() {

continue;

const sessions::SerializedNavigationEntry& current_navigation =

tab->navigations.at(tab->normalized_navigation_index());

- if (chrome::IsNTPURL(current_navigation.virtual_url(),

+ if (search::IsNTPURL(current_navigation.virtual_url(),

browser_->profile())) {

continue;

}

« no previous file with comments | « chrome/browser/ui/singleton_tabs.cc ('k') | chrome/browser/ui/toolbar/toolbar_model_impl.h » ('j') | no next file with comments »