chrome/browser/ui/singleton_tabs.cc - Issue 1260033003: Partially componentize //chrome/browser/search/search.{h,cc}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/singleton_tabs.cc

Issue 1260033003: Partially componentize //chrome/browser/search/search.{h,cc} (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix compilation on iOS Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/search/search_tab_helper_unittest.cc ('k') | chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/singleton_tabs.cc

diff --git a/chrome/browser/ui/singleton_tabs.cc b/chrome/browser/ui/singleton_tabs.cc

index 60cf852cd5c902d37ddd690445b0398a3d6208b9..7c450c4429b4c1f568fb521e061eb153073a4174 100644

--- a/chrome/browser/ui/singleton_tabs.cc

+++ b/chrome/browser/ui/singleton_tabs.cc

@@ -49,7 +49,8 @@ void ShowSingletonTabOverwritingNTP(Browser* browser,

browser->tab_strip_model()->GetActiveWebContents();

if (contents) {

const GURL& contents_url = contents->GetURL();

- if ((contents_url == GURL(kChromeUINewTabURL) || IsInstantNTP(contents) ||

+ if ((contents_url == GURL(kChromeUINewTabURL) ||

+ search::IsInstantNTP(contents) ||

contents_url == GURL(url::kAboutBlankURL)) &&

GetIndexOfSingletonTab(&local_params) < 0) {

local_params.disposition = CURRENT_TAB;

« no previous file with comments | « chrome/browser/ui/search/search_tab_helper_unittest.cc ('k') | chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc » ('j') | no next file with comments »