Remove the Finch test 'CLD1VsCLD2'

Remove the Finch test 'CLD1VsCLD2'

The Finch test 'CDL1VsCLD2' is a test to make sure that CLD2 is not
worse than CLD1 in terms of performance or accuracy. This test is no
longer executed on any platforms. Let's remove this for code health.

CLD version '0' is used to represent to use the Finch trial, and this
CL removes the cases of version 0 from gn, gypi and C++ files.

BUG=515358
Committed: https://crrev.com/92a5d22913c2ac3082d57d4eefa9911961588b41
Cr-Commit-Position: refs/heads/master@{#341496}

[hajimehoshi, 2015-07-30 07:59:32]

hajimehoshi@chromium.org changed reviewers:
+ brettw@chromium.org, toyoshim@chromium.org

[hajimehoshi, 2015-07-30 07:59:32]

PTAL

[Takashi Toyoshima, 2015-07-30 08:40:26]

toyoshim@chromium.org changed reviewers:
+ andrewhayden@chromium.org

[Takashi Toyoshima, 2015-07-30 08:41:05]

I think it's better if Andrew can double check build rule changes on CLD.

https://codereview.chromium.org/1259883007/diff/20001/build/config/BUILD.gn
File build/config/BUILD.gn (right):

https://codereview.chromium.org/1259883007/diff/20001/build/config/BUILD.gn#n...
build/config/BUILD.gn:48: defines += [ "CLD_VERSION=$cld_version" ]
defines = [
  "V8...",  # ...
  "CLD_..."
]
may be better?

https://codereview.chromium.org/1259883007/diff/20001/components/translate/co...
File components/translate/core/language_detection/language_detection_util.cc
(right):

https://codereview.chromium.org/1259883007/diff/20001/components/translate/co...
components/translate/core/language_detection/language_detection_util.cc:92:
cld_language != UNKNOWN_LANGUAGE &&
wrong indent

https://codereview.chromium.org/1259883007/diff/20001/components/translate/co...
components/translate/core/language_detection/language_detection_util.cc:112:
cld_language != CLD2::UNKNOWN_LANGUAGE &&
wrong indent

https://codereview.chromium.org/1259883007/diff/20001/components/translate/co...
components/translate/core/language_detection/language_detection_util.cc:114:
#endif
up to you, but could be something like this?

#if
  ...
#elif
  ...
#else
# error "CLD_VERSION should be 1 or 2"
#endif

https://codereview.chromium.org/1259883007/diff/20001/components/translate/co...
components/translate/core/language_detection/language_detection_util.cc:151:
#endif
ditto

[hajimehoshi, 2015-07-30 08:51:29]

Thank you!

https://codereview.chromium.org/1259883007/diff/20001/build/config/BUILD.gn
File build/config/BUILD.gn (right):

https://codereview.chromium.org/1259883007/diff/20001/build/config/BUILD.gn#n...
build/config/BUILD.gn:48: defines += [ "CLD_VERSION=$cld_version" ]
On 2015/07/30 08:41:05, Takashi Toyoshima (chromium) wrote:
> defines = [
>   "V8...",  # ...
>   "CLD_..."
> ]
> may be better?

Done.

https://codereview.chromium.org/1259883007/diff/20001/components/translate/co...
File components/translate/core/language_detection/language_detection_util.cc
(right):

https://codereview.chromium.org/1259883007/diff/20001/components/translate/co...
components/translate/core/language_detection/language_detection_util.cc:92:
cld_language != UNKNOWN_LANGUAGE &&
On 2015/07/30 08:41:05, Takashi Toyoshima (chromium) wrote:
> wrong indent

Done.

https://codereview.chromium.org/1259883007/diff/20001/components/translate/co...
components/translate/core/language_detection/language_detection_util.cc:112:
cld_language != CLD2::UNKNOWN_LANGUAGE &&
On 2015/07/30 08:41:05, Takashi Toyoshima (chromium) wrote:
> wrong indent

Done.

https://codereview.chromium.org/1259883007/diff/20001/components/translate/co...
components/translate/core/language_detection/language_detection_util.cc:114:
#endif
On 2015/07/30 08:41:05, Takashi Toyoshima (chromium) wrote:
> up to you, but could be something like this?
> 
> #if
>   ...
> #elif
>   ...
> #else
> # error "CLD_VERSION should be 1 or 2"
> #endif

Done.

https://codereview.chromium.org/1259883007/diff/20001/components/translate/co...
components/translate/core/language_detection/language_detection_util.cc:151:
#endif
On 2015/07/30 08:41:05, Takashi Toyoshima (chromium) wrote:
> ditto

Done.

[Takashi Toyoshima, 2015-07-30 09:00:04]

lgtm. But please wait for another comments from Andrew for translate build
dules, and owner's approval from Brett.

https://codereview.chromium.org/1259883007/diff/40001/build/config/BUILD.gn
File build/config/BUILD.gn (right):

https://codereview.chromium.org/1259883007/diff/40001/build/config/BUILD.gn#n...
build/config/BUILD.gn:48: "CLD_VERSION=$cld_version" ]
For multiple items,
foo = [
  "bar",
  "baz"
]
is chromium style for GN.
IIRC, there was a style check before, but is it removed?

[hajimehoshi, 2015-07-30 09:22:57]

https://codereview.chromium.org/1259883007/diff/40001/build/config/BUILD.gn
File build/config/BUILD.gn (right):

https://codereview.chromium.org/1259883007/diff/40001/build/config/BUILD.gn#n...
build/config/BUILD.gn:48: "CLD_VERSION=$cld_version" ]
On 2015/07/30 09:00:04, Takashi Toyoshima (chromium) wrote:
> For multiple items,
> foo = [
>   "bar",
>   "baz"
> ]
> is chromium style for GN.
> IIRC, there was a style check before, but is it removed?

Ugh, I didn't notice that there was a warning for the style on the pre-submit.
Thank you. Done

[andrewhayden, 2015-07-30 10:39:52]

andrewhayden@google.com changed reviewers:
+ andrewhayden@google.com

[andrewhayden, 2015-07-30 10:39:53]

LGTM. Thank you for the cleanup, I always wondered what version 0 meant :)

[brettw, 2015-07-31 23:50:12]

build files lgtm, I didn't look at the C++ code.

[hajimehoshi, 2015-08-03 04:20:51]

The CQ bit was checked by hajimehoshi@chromium.org

[hajimehoshi, 2015-08-03 04:20:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
toyoshim@chromium.org
Link to the patchset: https://codereview.chromium.org/1259883007/#ps60001
(title: "toyoshim's review")

[commit-bot: I haz the power, 2015-08-03 04:21:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1259883007/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1259883007/60001

[commit-bot: I haz the power, 2015-08-03 04:23:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-03 04:23:18]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[hajimehoshi, 2015-08-03 05:27:16]

The CQ bit was checked by hajimehoshi@chromium.org

[hajimehoshi, 2015-08-03 05:27:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
toyoshim@chromium.org, andrewhayden@google.com, brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1259883007/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2015-08-03 05:27:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1259883007/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1259883007/80001

[commit-bot: I haz the power, 2015-08-03 07:21:47]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-08-03 07:22:39]

Patchset 5 (id:??) landed as
https://crrev.com/92a5d22913c2ac3082d57d4eefa9911961588b41
Cr-Commit-Position: refs/heads/master@{#341496}