Remove the Finch test 'CLD1VsCLD2'

build/config/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/allocator.gni")
 import("//build/config/chrome_build.gni")
 import("//build/config/crypto.gni")
 import("//build/config/features.gni")
 import("//build/config/sanitizers/sanitizers.gni")
 import("//build/config/ui.gni")
@@ skipping 26 matching lines @@
 
 # TODO(brettw) Most of these should be removed. Instead of global feature
 # flags, we should have more modular flags that apply only to a target and its
 # dependents. For example, depending on the "x11" meta-target should define
 # USE_X11 for all dependents so that everything that could use X11 gets the
 # define, but anything that doesn't depend on X11 doesn't see it.
 #
 # For now we define these globally to match the current GYP build.
 config("feature_flags") {
   # TODO(brettw) this probably needs to be parameterized.
-  defines = [ "V8_DEPRECATION_WARNINGS" ]  # Don't use deprecated V8 APIs anywhere.
-
-  if (cld_version > 0) {
-    defines += [ "CLD_VERSION=$cld_version" ]
-  }
+  defines = [ "V8_DEPRECATION_WARNINGS",  # Don't use deprecated V8 APIs anywhere.
+              "CLD_VERSION=$cld_version" ]

[Takashi Toyoshima, 2015/07/30 09:00:04]

For multiple items,
foo = [
  "bar",
  "baz"
]
is chromium style for GN.
IIRC, there was a style check before, but is it removed?

[hajimehoshi, 2015/07/30 09:22:57]

Ugh, I didn't notice that there was a warning for the style on the pre-submit.
Thank you. Done

   if (enable_mdns) {
     defines += [ "ENABLE_MDNS=1" ]
   }
   if (enable_notifications) {
     defines += [ "ENABLE_NOTIFICATIONS" ]
   }
   if (enable_pepper_cdms) {
     # TODO(brettw) should probably be "=1"
     defines += [ "ENABLE_PEPPER_CDMS" ]
   }
@@ skipping 376 matching lines @@
     # with precompiled headers since the source file that's "compiled" for
     # making the precompiled header is empty.
     #
     # This error doesn't happen every time. In VS2013, it seems if the .pch
     # file doesn't exist, no error will be generated (probably MS tested this
     # case but forgot the other one?). To reproduce this error, do a build,
     # then delete the precompile.c.obj file, then build again.
     cflags_c = [ "/wd4206" ]
   }
 }