Update of change event for range input type

SliderThumb is responsible for sending onchange for range input type. It is updated to send change event in its defaultEventHandler only for mouse up event. 
Previously onchange was triggered for any position change

R=tkent             
BUG=155747
TEST=Range toggle test updated to generate onchange only on mouseUp.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165061

[Habib Virji, 2014-01-07 15:36:09]

Changes to limit change event being sent frequently for number, range and
datetime input field.

Spin Button includes changes for mouse and keyboard event. TextField has changes
to limit change event being sent only when not in focus.

Date time has changes to generate change event on any keyboard and on left
button click of mouse. Date time local since it uses both BaseMultipleFields and
BaseChooser, change event when popup is closed is handled in both. 

Slider has only mouse event changes.

[tkent, 2014-01-08 01:34:44]

Removed 	kenjibaheux from reviewers.  He is not an engineer.

[tkent, 2014-01-08 01:37:19]

This CL is trying to fix multiple problems at once.  Please split this into
multiple CLs. e.g. a CL for type=range, a CL for type=number, a CL for date/time
types.

https://codereview.chromium.org/125973004/diff/1/Source/core/html/forms/TextF...
File Source/core/html/forms/TextFieldInputType.cpp (right):

https://codereview.chromium.org/125973004/diff/1/Source/core/html/forms/TextF...
Source/core/html/forms/TextFieldInputType.cpp:170: case
DispatchInputAndChangeEvent:
This change is wrong.
If we need to make DispatchInputAndChangeEvent same as DispatchChangeEvent, we
should remove DispatchInputAndChangeEvent entirely.

[Habib Virji, 2014-01-08 12:22:41]

On 2014/01/08 01:37:19, tkent wrote:
> This CL is trying to fix multiple problems at once.  Please split this into
> multiple CLs. e.g. a CL for type=range, a CL for type=number, a CL for
date/time
> types.
> 
>
https://codereview.chromium.org/125973004/diff/1/Source/core/html/forms/TextF...
> File Source/core/html/forms/TextFieldInputType.cpp (right):
> 
>
https://codereview.chromium.org/125973004/diff/1/Source/core/html/forms/TextF...
> Source/core/html/forms/TextFieldInputType.cpp:170: case
> DispatchInputAndChangeEvent:
> This change is wrong.
> If we need to make DispatchInputAndChangeEvent same as DispatchChangeEvent, we
> should remove DispatchInputAndChangeEvent entirely.

Update CL for type=range. 
Other CL for type=number : https://codereview.chromium.org/128133002 
and CL for type=date/time: https://codereview.chromium.org/128153002

Current CL includes changes for sliderThumb. Any change on slider results in
call to setPosition; which use to trigger change event. Now change event is sent
when mouseup is triggered. Any keyboard event generates change event.

[tkent, 2014-01-14 01:00:51]

https://codereview.chromium.org/125973004/diff/70001/LayoutTests/fast/forms/r...
File LayoutTests/fast/forms/range/range-drag-when-toggled-disabled.html (left):

https://codereview.chromium.org/125973004/diff/70001/LayoutTests/fast/forms/r...
LayoutTests/fast/forms/range/range-drag-when-toggled-disabled.html:55:
shouldBeGreaterThanOrEqual('changeEventCounter', 'lastChangeEventCounter + 1');
We should check if 'change' event was NOT dispatched.

https://codereview.chromium.org/125973004/diff/70001/Source/core/html/shadow/...
File Source/core/html/shadow/SliderThumbElement.cpp (right):

https://codereview.chromium.org/125973004/diff/70001/Source/core/html/shadow/...
Source/core/html/shadow/SliderThumbElement.cpp:335:
input->dispatchFormControlChangeEvent();
I don't think this is necessary. RangeInputType::handleKeydownEvent() is
responsible for this.

https://codereview.chromium.org/125973004/diff/70001/Source/core/html/shadow/...
Source/core/html/shadow/SliderThumbElement.cpp:362:
input->dispatchFormControlChangeEvent();
This should be *in* stopDragging() because we need to dispatch 'change' event
when 'disabled' attribute is added during mouse dragging.

[Habib Virji, 2014-01-14 10:23:42]

Updated code as per review comments.

https://codereview.chromium.org/125973004/diff/70001/LayoutTests/fast/forms/r...
File LayoutTests/fast/forms/range/range-drag-when-toggled-disabled.html (left):

https://codereview.chromium.org/125973004/diff/70001/LayoutTests/fast/forms/r...
LayoutTests/fast/forms/range/range-drag-when-toggled-disabled.html:55:
shouldBeGreaterThanOrEqual('changeEventCounter', 'lastChangeEventCounter + 1');
On 2014/01/14 01:00:51, tkent wrote:
> We should check if 'change' event was NOT dispatched.

Done. Updated test to check change event is not triggered when value is changed.
The checkEventCounter will remain same, stopDrag(), only triggers increase of
checkEventCounter.

https://codereview.chromium.org/125973004/diff/70001/Source/core/html/shadow/...
File Source/core/html/shadow/SliderThumbElement.cpp (right):

https://codereview.chromium.org/125973004/diff/70001/Source/core/html/shadow/...
Source/core/html/shadow/SliderThumbElement.cpp:335:
input->dispatchFormControlChangeEvent();
On 2014/01/14 01:00:51, tkent wrote:
> I don't think this is necessary. RangeInputType::handleKeydownEvent() is
> responsible for this.

Done.

https://codereview.chromium.org/125973004/diff/70001/Source/core/html/shadow/...
Source/core/html/shadow/SliderThumbElement.cpp:362:
input->dispatchFormControlChangeEvent();
On 2014/01/14 01:00:51, tkent wrote:
> This should be *in* stopDragging() because we need to dispatch 'change' event
> when 'disabled' attribute is added during mouse dragging.

Done. Moved dispatchFormControlChangeEvent to stopDrag. Disabled attribute is
not checked as line 341 already checks before calling stopDrag

[tkent, 2014-01-14 10:29:22]

https://codereview.chromium.org/125973004/diff/130001/LayoutTests/fast/forms/...
File LayoutTests/fast/forms/range/range-drag-when-toggled-disabled.html (right):

https://codereview.chromium.org/125973004/diff/130001/LayoutTests/fast/forms/...
LayoutTests/fast/forms/range/range-drag-when-toggled-disabled.html:55:
shouldBeGreaterThanOrEqual('changeEventCounter', 'lastChangeEventCounter');
This line should be shouldBe(...), not shouldBeGreaterThanOrEqual(...).

[Habib Virji, 2014-01-14 10:56:18]

Updated as per review comment

https://codereview.chromium.org/125973004/diff/130001/LayoutTests/fast/forms/...
File LayoutTests/fast/forms/range/range-drag-when-toggled-disabled.html (right):

https://codereview.chromium.org/125973004/diff/130001/LayoutTests/fast/forms/...
LayoutTests/fast/forms/range/range-drag-when-toggled-disabled.html:55:
shouldBeGreaterThanOrEqual('changeEventCounter', 'lastChangeEventCounter');
On 2014/01/14 10:29:23, tkent wrote:
> This line should be shouldBe(...), not shouldBeGreaterThanOrEqual(...).

Done.

[tkent, 2014-01-14 10:57:13]

lgtm

[commit-bot: I haz the power, 2014-01-14 10:57:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/habib.virji@samsung.com/125973004/180001

[commit-bot: I haz the power, 2014-01-14 11:56:37]

Change committed as 165061