Update of change event for range input type

Source/core/html/shadow/SliderThumbElement.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 16 matching lines @@
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 
 #include "config.h"
 #include "core/html/shadow/SliderThumbElement.h"
 
 #include "core/events/Event.h"
+#include "core/events/KeyboardEvent.h"
 #include "core/events/MouseEvent.h"
 #include "core/dom/shadow/ShadowRoot.h"
 #include "core/html/HTMLInputElement.h"
 #include "core/html/forms/StepRange.h"
 #include "core/html/parser/HTMLParserIdioms.h"
 #include "core/html/shadow/ShadowElementNames.h"
 #include "core/page/EventHandler.h"
 #include "core/frame/Frame.h"
 #include "core/rendering/RenderFlexibleBox.h"
 #include "core/rendering/RenderSlider.h"
@@ skipping 251 matching lines @@
     }
 
     String valueString = serializeForNumberType(value);
     if (valueString == input->value())
         return;
 
     // FIXME: This is no longer being set from renderer. Consider updating the method name.
     input->setValueFromRenderer(valueString);
     if (renderer())
         renderer()->setNeedsLayout();
-    input->dispatchFormControlChangeEvent();
 }
 
 void SliderThumbElement::startDragging()
 {
     if (Frame* frame = document().frame()) {
         frame->eventHandler().setCapturingMouseEventsNode(this);
         m_inDragMode = true;
     }
 }
 
 void SliderThumbElement::stopDragging()
 {
     if (!m_inDragMode)
         return;
 
     if (Frame* frame = document().frame())
         frame->eventHandler().setCapturingMouseEventsNode(0);
     m_inDragMode = false;
     if (renderer())
         renderer()->setNeedsLayout();
 }
 
 void SliderThumbElement::defaultEventHandler(Event* event)
 {
+    HTMLInputElement* input = hostInput();
+    if (event->isKeyboardEvent()) {
+        input->dispatchFormControlChangeEvent();

[tkent, 2014/01/14 01:00:51]

I don't think this is necessary. RangeInputType::handleKeydownEvent() is
responsible for this.

[Habib Virji, 2014/01/14 10:23:42]

Done.

+    }
+
     if (!event->isMouseEvent()) {
         HTMLDivElement::defaultEventHandler(event);
         return;
     }
 
     // FIXME: Should handle this readonly/disabled check in more general way.
     // Missing this kind of check is likely to occur elsewhere if adding it in each shadow element.
-    HTMLInputElement* input = hostInput();
     if (!input || input->isDisabledOrReadOnly()) {
         stopDragging();
         HTMLDivElement::defaultEventHandler(event);
         return;
     }
 
     MouseEvent* mouseEvent = toMouseEvent(event);
     bool isLeftButton = mouseEvent->button() == LeftButton;
     const AtomicString& eventType = event->type();
 
     // We intentionally do not call event->setDefaultHandled() here because
     // MediaControlTimelineElement::defaultEventHandler() wants to handle these
     // mouse events.
     if (eventType == EventTypeNames::mousedown && isLeftButton) {
         startDragging();
         return;
     } else if (eventType == EventTypeNames::mouseup && isLeftButton) {
+        input->dispatchFormControlChangeEvent();

[tkent, 2014/01/14 01:00:51]

This should be *in* stopDragging() because we need to dispatch 'change' event
when 'disabled' attribute is added during mouse dragging.

[Habib Virji, 2014/01/14 10:23:42]

Done. Moved dispatchFormControlChangeEvent to stopDrag. Disabled attribute is
not checked as line 341 already checks before calling stopDrag

         stopDragging();
         return;
     } else if (eventType == EventTypeNames::mousemove) {
         if (m_inDragMode)
             setPositionFromPoint(mouseEvent->absoluteLocation());
         return;
     }
 
     HTMLDivElement::defaultEventHandler(event);
 }
@@ skipping 97 matching lines @@
     case MediaVolumeSliderThumbPart:
     case MediaFullScreenVolumeSliderPart:
     case MediaFullScreenVolumeSliderThumbPart:
         return mediaSliderContainer;
     default:
         return sliderContainer;
     }
 }
 
 }