content/renderer/media/mock_web_rtc_peer_connection_handler_client.cc - Issue 1259673002: Make UTF16ToASCII and UTF16TOUTF8 take a StringPiece

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/mock_web_rtc_peer_connection_handler_client.cc

Issue 1259673002: Make UTF16ToASCII and UTF16TOUTF8 take a StringPiece (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/media_stream_renderer_factory_impl.cc ('k') | content/renderer/media/peer_connection_tracker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/mock_web_rtc_peer_connection_handler_client.cc

diff --git a/content/renderer/media/mock_web_rtc_peer_connection_handler_client.cc b/content/renderer/media/mock_web_rtc_peer_connection_handler_client.cc

index a4b8e5501339f929a180fa9e8d37d31a3bebce33..825a212f42bf24953f8db4628f24da3ef1716eec 100644

--- a/content/renderer/media/mock_web_rtc_peer_connection_handler_client.cc

+++ b/content/renderer/media/mock_web_rtc_peer_connection_handler_client.cc

@@ -32,9 +32,10 @@ MockWebRTCPeerConnectionHandlerClient::

void MockWebRTCPeerConnectionHandlerClient::didGenerateICECandidateWorker(

const blink::WebRTCICECandidate& candidate) {

if (!candidate.isNull()) {

- candidate_sdp_ = base::UTF16ToUTF8(candidate.candidate());

+ candidate_sdp_ =

+ base::UTF16ToUTF8(base::StringPiece16(candidate.candidate()));

candidate_mline_index_ = candidate.sdpMLineIndex();

- candidate_mid_ = base::UTF16ToUTF8(candidate.sdpMid());

+ candidate_mid_ = base::UTF16ToUTF8(base::StringPiece16(candidate.sdpMid()));

} else {

candidate_sdp_ = "";

candidate_mline_index_ = -1;

« no previous file with comments | « content/renderer/media/media_stream_renderer_factory_impl.cc ('k') | content/renderer/media/peer_connection_tracker.cc » ('j') | no next file with comments »