content/renderer/media/media_stream_renderer_factory_impl.cc - Issue 1259673002: Make UTF16ToASCII and UTF16TOUTF8 take a StringPiece

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/media_stream_renderer_factory_impl.cc

Issue 1259673002: Make UTF16ToASCII and UTF16TOUTF8 take a StringPiece (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/android/webmediaplayer_android.cc ('k') | content/renderer/media/mock_web_rtc_peer_connection_handler_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/media_stream_renderer_factory_impl.cc

diff --git a/content/renderer/media/media_stream_renderer_factory_impl.cc b/content/renderer/media/media_stream_renderer_factory_impl.cc

index cfc37a7380256ff546b8a9e94a35e63502afd80a..2d0659a9eda46836607866d05b32f849c7508778 100644

--- a/content/renderer/media/media_stream_renderer_factory_impl.cc

+++ b/content/renderer/media/media_stream_renderer_factory_impl.cc

@@ -120,7 +120,7 @@ MediaStreamRendererFactoryImpl::GetVideoFrameProvider(

DCHECK(!web_stream.isNull());

DVLOG(1) << "MediaStreamRendererFactoryImpl::GetVideoFrameProvider stream:"

- << base::UTF16ToUTF8(web_stream.id());

+ << base::UTF16ToUTF8(base::StringPiece16(web_stream.id()));

blink::WebVector<blink::WebMediaStreamTrack> video_tracks;

web_stream.videoTracks(video_tracks);

@@ -142,7 +142,7 @@ MediaStreamRendererFactoryImpl::GetAudioRenderer(const GURL& url,

return NULL; // This is not a valid stream.

DVLOG(1) << "MediaStreamRendererFactoryImpl::GetAudioRenderer stream:"

- << base::UTF16ToUTF8(web_stream.id());

+ << base::UTF16ToUTF8(base::StringPiece16(web_stream.id()));

MediaStream* native_stream = MediaStream::GetMediaStream(web_stream);