Chromium Code Reviews| Index: Source/modules/mediasession/MediaSession.h |
| diff --git a/Source/modules/mediasession/MediaSession.h b/Source/modules/mediasession/MediaSession.h |
| index bb9ce15e275adb89d5a6c5759c1dcc1aa486de4d..80d955d0e98c30e22fd1b8f1893fd991a96f2ca4 100644 |
| --- a/Source/modules/mediasession/MediaSession.h |
| +++ b/Source/modules/mediasession/MediaSession.h |
| @@ -6,14 +6,23 @@ |
| #define MediaSession_h |
| #include "bindings/core/v8/ScriptWrappable.h" |
| +#include "modules/ModulesExport.h" |
| #include "platform/heap/Handle.h" |
| +#include "public/platform/WebMediaSession.h" |
| +#include "wtf/OwnPtr.h" |
| namespace blink { |
| -class MediaSession : public GarbageCollected<MediaSession>, public ScriptWrappable { |
| +class ScriptState; |
| +class WebMediaSession; |
| + |
| +class MODULES_EXPORT MediaSession |
|
whywhat
2015/08/24 14:30:03
Please, add some comments for the class and its (a
|
| + : public GarbageCollectedFinalized<MediaSession> |
| + , public ScriptWrappable { |
| DEFINE_WRAPPERTYPEINFO(); |
| public: |
| - static MediaSession* create(); |
| + static MediaSession* create(ScriptState*); |
| + static MediaSession* createForTesting(PassOwnPtr<WebMediaSession>); |
| void activate(); |
| void deactivate(); |
| @@ -21,7 +30,9 @@ public: |
| DEFINE_INLINE_TRACE() { } |
| private: |
| - MediaSession() = default; |
| + MediaSession(PassOwnPtr<WebMediaSession>); |
|
whywhat
2015/08/24 14:30:03
nit: use explicit keyword
|
| + |
| + OwnPtr<WebMediaSession> m_webMediaSession; |
|
whywhat
2015/08/24 14:30:03
Shouldn't this live on the Oilpan heap (e.g. be a
|
| }; |
| } // namespace blink |