NOT FOR LANDING Introduce and use WebMediaSession

NOT FOR LANDING Introduce and use WebMediaSession

Chromium CL: https://codereview.chromium.org/1259633002/

BUG=497735

[whywhat, 2015-08-24 14:30:02]

avayvod@chromium.org changed reviewers:
+ avayvod@chromium.org

[whywhat, 2015-08-24 14:30:03]

https://codereview.chromium.org/1259643002/diff/40001/Source/modules/mediases...
File Source/modules/mediasession/MediaSession.h (right):

https://codereview.chromium.org/1259643002/diff/40001/Source/modules/mediases...
Source/modules/mediasession/MediaSession.h:19: class MODULES_EXPORT MediaSession
Please, add some comments for the class and its (at least public) members.

https://codereview.chromium.org/1259643002/diff/40001/Source/modules/mediases...
Source/modules/mediasession/MediaSession.h:33:
MediaSession(PassOwnPtr<WebMediaSession>);
nit: use explicit keyword

https://codereview.chromium.org/1259643002/diff/40001/Source/modules/mediases...
Source/modules/mediasession/MediaSession.h:35: OwnPtr<WebMediaSession>
m_webMediaSession;
Shouldn't this live on the Oilpan heap (e.g. be a Member)?

[philipj_slow, 2015-10-09 09:35:55]

Superseded by https://codereview.chromium.org/1370453002/

[joecool, 2015-10-09 15:49:37]

What does 'not for landing' mean?

On Friday, October 9, 2015 at 2:35:55 AM UTC-7, phi...@opera.com wrote:
>
> Reviewers: whywhat, 
>
> Message: 
> Superseded by https://codereview.chromium.org/1370453002/ 
>
> Description: 
> NOT FOR LANDING Introduce and use WebMediaSession 
>
> Chromium CL: https://codereview.chromium.org/1259633002/ 
>
> BUG=497735 
>
> Please review this at https://codereview.chromium.org/1259643002/ 
>
> Base URL: svn://svn.chromium.org/blink/trunk 
>
> Affected files (+120, -12 lines): 
>    M Source/core/loader/EmptyClients.h 
>    M Source/core/loader/EmptyClients.cpp 
>    M Source/core/loader/FrameLoaderClient.h 
>    M Source/modules/mediasession/MediaSession.h 
>    M Source/modules/mediasession/MediaSession.cpp 
>    M Source/modules/mediasession/MediaSession.idl 
>    A Source/modules/mediasession/MediaSessionTest.cpp 
>    M Source/modules/modules.gypi 
>    M Source/web/FrameLoaderClientImpl.h 
>    M Source/web/FrameLoaderClientImpl.cpp 
>    M public/BUILD.gn 
>    A + public/platform/WebMediaSession.h 
>    M public/web/WebFrameClient.h 
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[philipj_slow, 2015-10-10 17:28:55]

On 2015/10/09 15:49:37, jmedley1 wrote:
> What does 'not for landing' mean?

It means that this CL was incomplete and not ready for final review (or landing)
when I uploaded it.