Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 12596015: cc: Keep a reference on the media::VideoFrame. (Closed)

Created:
7 years, 9 months ago by danakj
Modified:
7 years, 9 months ago
Reviewers:
jamesr
CC:
chromium-reviews, feature-media-reviews_chromium.org, cc-bugs_chromium.org, piman, backer
Visibility:
Public.

Description

cc: Keep a reference on the media::VideoFrame. When we remove WebVideoFrame, we need cc::VideoLayerImpl to hold a reference to the VideoFrame while it is using it, else it may disappear while the layer is trying to draw from it. R=jamesr BUG=196810 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189834

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M cc/layers/video_frame_provider.h View 1 chunk +4 lines, -4 lines 0 comments Download
M cc/layers/video_frame_provider_client_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layers/video_frame_provider_client_impl.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M cc/layers/video_layer_impl.h View 1 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 8 (0 generated)
danakj
7 years, 9 months ago (2013-03-21 17:57:08 UTC) #1
scherkus (not reviewing)
(drive by) https://codereview.chromium.org/12596015/diff/3001/cc/layers/video_layer_impl.h File cc/layers/video_layer_impl.h (right): https://codereview.chromium.org/12596015/diff/3001/cc/layers/video_layer_impl.h#newcode74 cc/layers/video_layer_impl.h:74: media::VideoFrame::Format format_; perhaps something to tackle in ...
7 years, 9 months ago (2013-03-21 20:29:56 UTC) #2
danakj
https://codereview.chromium.org/12596015/diff/3001/cc/layers/video_layer_impl.h File cc/layers/video_layer_impl.h (right): https://codereview.chromium.org/12596015/diff/3001/cc/layers/video_layer_impl.h#newcode74 cc/layers/video_layer_impl.h:74: media::VideoFrame::Format format_; On 2013/03/21 20:29:56, scherkus wrote: > perhaps ...
7 years, 9 months ago (2013-03-21 20:31:20 UTC) #3
scherkus (not reviewing)
On 2013/03/21 20:31:20, danakj wrote: > https://codereview.chromium.org/12596015/diff/3001/cc/layers/video_layer_impl.h > File cc/layers/video_layer_impl.h (right): > > https://codereview.chromium.org/12596015/diff/3001/cc/layers/video_layer_impl.h#newcode74 > ...
7 years, 9 months ago (2013-03-21 20:35:33 UTC) #4
jamesr
lgtm
7 years, 9 months ago (2013-03-22 00:08:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/12596015/3001
7 years, 9 months ago (2013-03-22 00:26:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/12596015/3001
7 years, 9 months ago (2013-03-22 16:46:47 UTC) #7
commit-bot: I haz the power
7 years, 9 months ago (2013-03-22 16:56:19 UTC) #8
Message was sent while issue was closed.
Change committed as 189834

Powered by Google App Engine
This is Rietveld 408576698