Issue 1259593010: Fix issue with longpress drag selection motion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1259593010: Fix issue with longpress drag selection motion (Closed)

Created:
5 years, 4 months ago by jdduke (slow)

Modified:
5 years, 4 months ago

Reviewers:

CC:
chromium-reviews, dcheng

Base URL:
https://chromium.googlesource.com/chromium/src.git@2454

Target Ref:
refs/pending/branch-heads/2454

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix issue with longpress drag selection motion If the user has already dragged outside the initial selected word region by the time the browser gets a selection update, or if the selected word isn't coincident with the longpress location, the subsequently dragged selection endpoint can be wrong. For such cases, rather than using the drag direction for drag anchor picking, just use the distance between the current touch point and the selection endpoints. BUG=466749 Review URL: https://codereview.chromium.org/1271823002 Cr-Commit-Position: refs/heads/master@{#341791} (cherry picked from commit a188bd6dff9c2a0425d1f31e3ab929c373762d83) Committed: https://chromium.googlesource.com/chromium/src/+/5e1e7b4ddecf1f57f16bdbe936e7bd0eaddf9b0b

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -12 lines)			Patch
	M	ui/touch_selection/longpress_drag_selector.cc	View		2 chunks	+24 lines, -11 lines	0 comments	Download
	M	ui/touch_selection/longpress_drag_selector_unittest.cc	View		2 chunks	+35 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

jdduke (slow)

5 years, 4 months ago (2015-08-04 23:51:32 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5e1e7b4ddecf1f57f16bdbe936e7bd0eaddf9b0b.

Expand Messages | Collapse Messages