Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 1259513004: compute split conic endpoints exactly (Closed)

Created:
5 years, 4 months ago by caryclark
Modified:
5 years, 4 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

compute split conic endpoints exactly The divide by w can generate slightly erroneous results even for t == 0 or t == 1. The error in turn defeats detecting a point in common for a pair of curves that travel in opposite directions. Instead, special case endpoints when the t is 0 or 1. TBR=reed@google.com BUG=514118 Committed: https://skia.googlesource.com/skia/+/bb134333648c5e44e00a95b8323033a6264ecae0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -6 lines) Patch
M src/pathops/SkPathOpsConic.cpp View 2 chunks +34 lines, -6 lines 0 comments Download
M tests/PathOpsSimplifyTest.cpp View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259513004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259513004/1
5 years, 4 months ago (2015-07-28 12:04:57 UTC) #2
commit-bot: I haz the power
5 years, 4 months ago (2015-07-28 12:12:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/bb134333648c5e44e00a95b8323033a6264ecae0

Powered by Google App Engine
This is Rietveld 408576698