Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1259363004: MD downloads: fix more date and page title issues (Closed)

Created:
5 years, 4 months ago by Dan Beam
Modified:
5 years, 4 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@dl-items5
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD downloads: fix more date and page title issues - Implement day separators - Fix date font color/size/weight - Fix page title font size Prev CL: https://codereview.chromium.org/1257413004/ Next CL: https://codereview.chromium.org/1264553002/ R=michaelpg@chromium.org BUG=425626 Committed: https://crrev.com/ddd6a86f9edf7a8af927bcc7d2f2b6b3958517bc Cr-Commit-Position: refs/heads/master@{#341089}

Patch Set 1 : merge #

Total comments: 3

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -41 lines) Patch
M chrome/browser/resources/md_downloads/item.css View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_downloads/item.html View 1 1 chunk +45 lines, -41 lines 0 comments Download
M chrome/browser/resources/md_downloads/toolbar.css View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
Dan Beam
screenshot: http://i.imgur.com/xSrTeJW.png https://codereview.chromium.org/1259363004/diff/20001/chrome/browser/resources/md_downloads/item.html File chrome/browser/resources/md_downloads/item.html (right): https://codereview.chromium.org/1259363004/diff/20001/chrome/browser/resources/md_downloads/item.html#newcode19 chrome/browser/resources/md_downloads/item.html:19: <div id="content-wrapper"> hard to tell here, but ...
5 years, 4 months ago (2015-07-29 03:09:37 UTC) #2
michaelpg
lgtm https://codereview.chromium.org/1259363004/diff/20001/chrome/browser/resources/md_downloads/item.css File chrome/browser/resources/md_downloads/item.css (right): https://codereview.chromium.org/1259363004/diff/20001/chrome/browser/resources/md_downloads/item.css#newcode16 chrome/browser/resources/md_downloads/item.css:16: :host(:not(:first-of-type):not([hide-date])) :-webkit-any(#content-wrapper, this line: https://memegen.googleplex.com/templateimage?template=whoa4 :-webkit-any: https://memegen.googleplex.com/templateimage?template=mind_blown :host(): ...
5 years, 4 months ago (2015-07-30 02:39:20 UTC) #4
Dan Beam
https://codereview.chromium.org/1259363004/diff/20001/chrome/browser/resources/md_downloads/item.css File chrome/browser/resources/md_downloads/item.css (right): https://codereview.chromium.org/1259363004/diff/20001/chrome/browser/resources/md_downloads/item.css#newcode16 chrome/browser/resources/md_downloads/item.css:16: :host(:not(:first-of-type):not([hide-date])) :-webkit-any(#content-wrapper, On 2015/07/30 02:39:20, michaelpg wrote: > this ...
5 years, 4 months ago (2015-07-30 02:46:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259363004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259363004/40001
5 years, 4 months ago (2015-07-30 08:11:06 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 4 months ago (2015-07-30 08:55:39 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 08:56:18 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ddd6a86f9edf7a8af927bcc7d2f2b6b3958517bc
Cr-Commit-Position: refs/heads/master@{#341089}

Powered by Google App Engine
This is Rietveld 408576698