Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 1257413004: Keep hackin' on MD downloads (Closed)

Created:
5 years, 4 months ago by Dan Beam
Modified:
5 years, 4 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@dl-items4
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Keep hackin' on MD downloads - Implement dangerous downloads - Combine safe and dangerous HTML (UI is very similar in MD) - Create a "tag" and move "Canceled" there - Disable (X) when downloading (rather than hide) - Fix some more colors Next CL: https://codereview.chromium.org/1259363004/ R=michaelpg@chromium.org BUG=425626 Committed: https://crrev.com/1c2cc85f6137afdbfcd2bae143e564425d7a0747 Cr-Commit-Position: refs/heads/master@{#341060}

Patch Set 1 : mo fixes #

Patch Set 2 : merge master #

Patch Set 3 : small fixes #

Patch Set 4 : stupid whitespace #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -95 lines) Patch
M chrome/browser/resources/md_downloads/item.css View 1 2 5 chunks +36 lines, -22 lines 1 comment Download
M chrome/browser/resources/md_downloads/item.html View 1 2 3 2 chunks +29 lines, -32 lines 0 comments Download
M chrome/browser/resources/md_downloads/item.js View 1 2 5 chunks +48 lines, -41 lines 2 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (3 generated)
Dan Beam
5 years, 4 months ago (2015-07-29 01:34:23 UTC) #3
Dan Beam
screenshot: http://i.imgur.com/ungVwuM.png
5 years, 4 months ago (2015-07-29 03:30:06 UTC) #4
michaelpg
lgtm lgtm and looking good! https://codereview.chromium.org/1257413004/diff/100001/chrome/browser/resources/md_downloads/item.js File chrome/browser/resources/md_downloads/item.js (right): https://codereview.chromium.org/1257413004/diff/100001/chrome/browser/resources/md_downloads/item.js#newcode228 chrome/browser/resources/md_downloads/item.js:228: assert(!this.$.remove.disabled); Don't trust Polymer?
5 years, 4 months ago (2015-07-30 02:39:24 UTC) #5
Dan Beam
https://codereview.chromium.org/1257413004/diff/100001/chrome/browser/resources/md_downloads/item.js File chrome/browser/resources/md_downloads/item.js (right): https://codereview.chromium.org/1257413004/diff/100001/chrome/browser/resources/md_downloads/item.js#newcode228 chrome/browser/resources/md_downloads/item.js:228: assert(!this.$.remove.disabled); On 2015/07/30 02:39:24, michaelpg wrote: > Don't trust ...
5 years, 4 months ago (2015-07-30 02:43:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257413004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257413004/100001
5 years, 4 months ago (2015-07-30 02:43:50 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:100001)
5 years, 4 months ago (2015-07-30 02:48:19 UTC) #9
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/1c2cc85f6137afdbfcd2bae143e564425d7a0747 Cr-Commit-Position: refs/heads/master@{#341060}
5 years, 4 months ago (2015-07-30 02:49:10 UTC) #10
michaelpg
5 years, 4 months ago (2015-07-30 02:49:34 UTC) #11
Message was sent while issue was closed.
https://codereview.chromium.org/1257413004/diff/100001/chrome/browser/resourc...
File chrome/browser/resources/md_downloads/item.css (left):

https://codereview.chromium.org/1257413004/diff/100001/chrome/browser/resourc...
chrome/browser/resources/md_downloads/item.css:31: border-radius: 2px;  /*
TODO(dbeam): why does this differ from Polymer? */
didn't we do this already?

Powered by Google App Engine
This is Rietveld 408576698