Make VisiblePosition::characterAfter() not to use Position::containerText()

Make VisiblePosition::characterAfter() not to use Position::containerText()

This patch changes |VisiblePosition::characterAfter()| not to use
|Position::containerText()| by using |toText()| to avoid redundant call
of |Position::containerNode()| and |Position::containerText()| for improving
code health.

This patch is a preparation of templatizing |VisiblePosition| and getting rid
of |Position::containerText()|.

BUG=513568
TEST=n/a; no behavior changes

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199932

[yosin_UTC9, 2015-08-03 08:01:16]

yosin@chromium.org changed reviewers:
+ hajimehoshi@chromium.org, tkent@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2015-08-03 09:06:32]

PTAL

[yoichio, 2015-08-04 01:36:07]

https://codereview.chromium.org/1259243007/diff/1/Source/core/editing/Visible...
File Source/core/editing/VisiblePosition.cpp (right):

https://codereview.chromium.org/1259243007/diff/1/Source/core/editing/Visible...
Source/core/editing/VisiblePosition.cpp:667: if (!containerNode ||
!containerNode->isTextNode() || !pos.isOffsetInAnchor())
Could you early return if |!pos.isOffsetInAnchor()| not to call
pos.containerNode?

[yosin_UTC9, 2015-08-04 01:45:55]

PTAL

https://codereview.chromium.org/1259243007/diff/1/Source/core/editing/Visible...
File Source/core/editing/VisiblePosition.cpp (right):

https://codereview.chromium.org/1259243007/diff/1/Source/core/editing/Visible...
Source/core/editing/VisiblePosition.cpp:667: if (!containerNode ||
!containerNode->isTextNode() || !pos.isOffsetInAnchor())
On 2015/08/04 01:36:07, yoichio wrote:
> Could you early return if |!pos.isOffsetInAnchor()| not to call
> pos.containerNode?

Done.

[yoichio, 2015-08-04 01:51:50]

The CQ bit was checked by yoichio@chromium.org

[yoichio, 2015-08-04 01:51:51]

lgtm

[commit-bot: I haz the power, 2015-08-04 01:52:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1259243007/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1259243007/20001

[commit-bot: I haz the power, 2015-08-04 02:45:17]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199932