src/objects-inl.h - Issue 1259193004: [Interpreter] Consistency fixes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-inl.h

Issue 1259193004: [Interpreter] Consistency fixes. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Remove redundant argument to Bytecodes::Decode(). Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects-inl.h

diff --git a/src/objects-inl.h b/src/objects-inl.h

index 4929c0d2dfd56a70900d070e8d2b2e87f52120c2..1a7cee57e85303f2b9783c36aa42f9fe69bfba59 100644

--- a/src/objects-inl.h

+++ b/src/objects-inl.h

@@ -3614,8 +3614,7 @@ void BytecodeArray::set(int index, byte value) {

void BytecodeArray::set_frame_size(int frame_size) {

- // We need at least one stack slot for the return register.

- DCHECK_GE(frame_size, kPointerSize);

+ DCHECK_GE(frame_size, 0);

DCHECK(IsAligned(frame_size, static_cast<unsigned>(kPointerSize)));

WRITE_INT_FIELD(this, kFrameSizeOffset, frame_size);

}

« no previous file with comments | « src/objects.cc ('k') | test/cctest/interpreter/test-bytecode-array-builder.cc » ('j') | no next file with comments »