Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 1258903002: Extract `mojo_test` - standalone apptest runner in devtools. (Closed)

Created:
5 years, 4 months ago by ppi
Modified:
5 years, 4 months ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Extract `mojo_test` - standalone apptest runner in devtools. This patch adds a standalone script for running apptests in devtools, and makes the Mojo repo mojo/tools/apptest_runner.py script a wrapper that builds a command line for `mojo_test` and defers to it. This allows Mojo consumers to directly rely on mojo_run + mojo_test, without embedding devtoolslib themselves. Fixes domokit/devtools#29. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/62b7a16b836f1a08e7ac53aedfdf43016325d364

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Ben's comments. #

Patch Set 3 : Centralize the documentation in mojo_test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -68 lines) Patch
M mojo/devtools/common/README.md View 3 chunks +12 lines, -11 lines 0 comments Download
M mojo/devtools/common/devtoolslib/apptest_runner.py View 1 2 2 chunks +3 lines, -22 lines 0 comments Download
A mojo/devtools/common/mojo_test View 1 2 1 chunk +101 lines, -0 lines 0 comments Download
M mojo/tools/apptest_runner.py View 3 chunks +17 lines, -24 lines 0 comments Download
M mojo/tools/data/apptests View 1 2 4 chunks +5 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
ppi
Hi Ben, ptal.
5 years, 4 months ago (2015-07-27 09:08:31 UTC) #2
qsr
https://codereview.chromium.org/1258903002/diff/1/mojo/tools/data/apptests File mojo/tools/data/apptests (right): https://codereview.chromium.org/1258903002/diff/1/mojo/tools/data/apptests#newcode4 mojo/tools/data/apptests:4: # mopy.config.Config object, and must set a |tests| global ...
5 years, 4 months ago (2015-07-27 09:25:15 UTC) #3
ppi
https://codereview.chromium.org/1258903002/diff/1/mojo/tools/data/apptests File mojo/tools/data/apptests (right): https://codereview.chromium.org/1258903002/diff/1/mojo/tools/data/apptests#newcode4 mojo/tools/data/apptests:4: # mopy.config.Config object, and must set a |tests| global ...
5 years, 4 months ago (2015-07-27 10:03:04 UTC) #4
ppi
Centralized the documentation as discussed offline, ptal.
5 years, 4 months ago (2015-07-27 11:00:48 UTC) #5
qsr
lgtm
5 years, 4 months ago (2015-07-27 11:34:13 UTC) #6
ppi
5 years, 4 months ago (2015-07-27 11:43:18 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
62b7a16b836f1a08e7ac53aedfdf43016325d364 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698