Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: mojo/devtools/common/devtoolslib/apptest_runner.py

Issue 1258903002: Extract `mojo_test` - standalone apptest runner in devtools. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Centralize the documentation in mojo_test. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/devtools/common/README.md ('k') | mojo/devtools/common/mojo_test » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/devtools/common/devtoolslib/apptest_runner.py
diff --git a/mojo/devtools/common/devtoolslib/apptest_runner.py b/mojo/devtools/common/devtoolslib/apptest_runner.py
index 1357d520d3dbd1821d1a5045a6a544e298e67554..f95199405ad5f463b96a4cae91706b2070a83896 100644
--- a/mojo/devtools/common/devtoolslib/apptest_runner.py
+++ b/mojo/devtools/common/devtoolslib/apptest_runner.py
@@ -4,27 +4,8 @@
"""High-level apptest runner that runs all tests specified in a list.
-The list of tests has to contain one dictionary per test to be run, in the
-following form:
-
- {
- # Required URL for apptest.
- "test": "mojo:test_app_url",
- # Optional display name (otherwise the entry for "test" above is used).
- "name": "mojo:test_app_url (more details)",
- # Optional test type. Valid values:
- # * "gtest" (default)
- # * "gtest_isolated": like "gtest", but run with fixture isolation,
- # i.e., each test in a fresh mojo_shell)
- # * "dart".
- "type": "gtest",
- # Optional arguments for the apptest.
- "test-args": ["--an_arg", "another_arg"],
- # Optional arguments for the shell.
- "shell-args": ["--some-flag-for-the-shell", "--another-flag"],
- }
-
-TODO(vtl|msw): Add a way of specifying data dependencies.
+TODO(ppi): merge this into `mojo_test` once all clients are switched to use
+`mojo_test` instead of calling run_apptests() directly.
"""
import sys
@@ -44,7 +25,7 @@ def run_apptests(shell, common_shell_args, test_list):
common_shell_args: Arguments that will be passed to the shell on each run.
These will be appended to the shell-args specified for individual tests.
test_list: List of tests to be run in the format described in the
- docstring of this module.
+ docstring of `mojo_test`.
Returns:
True iff all tests succeeded, False otherwise.
« no previous file with comments | « mojo/devtools/common/README.md ('k') | mojo/devtools/common/mojo_test » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698