Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1258883003: Get rid of subtract-one-whole-pixel hack. (Closed)

Created:
5 years, 4 months ago by mstensho (USE GERRIT)
Modified:
5 years, 3 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mstensho (USE GERRIT), pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Get rid of subtract-one-whole-pixel hack. Rectangles in Blink are endpoint-exclusive. There's a hack in the multicol code to work around this (when mapping from block positions to column indices), but it's not corner-case-proof. It both causes rendering errors and a recently added assertion to fail. Fixed this. R=dsinclair@chromium.org,jchaffraix@chromium.org,leviw@chromium.org Committed: https://crrev.com/1280f55c1f7f7a40b2f49cfa60aaa8775ac1661e git-svn-id: svn://svn.chromium.org/blink/trunk@199683 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -3 lines) Patch
A LayoutTests/fast/multicol/less-than-one-pixel-tall-layer-at-column-top.html View 1 chunk +6 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/less-than-one-pixel-tall-layer-at-column-top-expected.html View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/layout/MultiColumnFragmentainerGroup.h View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/layout/MultiColumnFragmentainerGroup.cpp View 2 chunks +14 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
mstensho (USE GERRIT)
5 years, 4 months ago (2015-07-29 11:11:01 UTC) #1
leviw_travelin_and_unemployed
lgtm
5 years, 4 months ago (2015-07-29 21:13:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1258883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1258883003/1
5 years, 4 months ago (2015-07-29 21:13:45 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=199683
5 years, 4 months ago (2015-07-29 22:20:20 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 11:54:24 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1280f55c1f7f7a40b2f49cfa60aaa8775ac1661e

Powered by Google App Engine
This is Rietveld 408576698