Source/core/layout/MultiColumnFragmentainerGroup.h - Issue 1258883003: Get rid of subtract-one-whole-pixel hack.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/MultiColumnFragmentainerGroup.h

Issue 1258883003: Get rid of subtract-one-whole-pixel hack. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/multicol/less-than-one-pixel-tall-layer-at-column-top-expected.html ('k') | Source/core/layout/MultiColumnFragmentainerGroup.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/layout/MultiColumnFragmentainerGroup.h

diff --git a/Source/core/layout/MultiColumnFragmentainerGroup.h b/Source/core/layout/MultiColumnFragmentainerGroup.h

index 04f4534a8cf76cc1d6cba3204fbd214f1f6e407f..cde20858e0b2ab3ec873a60020d8b9d7e01afe1f 100644

--- a/Source/core/layout/MultiColumnFragmentainerGroup.h

+++ b/Source/core/layout/MultiColumnFragmentainerGroup.h

@@ -99,6 +99,10 @@ private:

// not inside any of the columns.

unsigned columnIndexAtVisualPoint(const LayoutPoint& visualPoint) const;

+ // Get the first and the last column intersecting the specified block range.

+ // Note that |logicalBottomInFlowThread| is an exclusive endpoint.

+ void columnIntervalForBlockRangeInFlowThread(LayoutUnit logicalTopInFlowThread, LayoutUnit logicalBottomInFlowThread, unsigned& firstColumn, unsigned& lastColumn) const;

// Get the first and the last column intersecting the specified visual rectangle.

void columnIntervalForVisualRect(const LayoutRect&, unsigned& firstColumn, unsigned& lastColumn) const;