[Sync] Add more info for invalid position check

Add more info for invalid position check.

BUG=332371
Committed: https://crrev.com/81f85526af97a9e160aa839c9460b535694a0e04
Cr-Commit-Position: refs/heads/master@{#342437}

[Gang Wu, 2015-08-07 15:32:43]

gangwu@chromium.org changed reviewers:
+ stanisc@chromium.org

[stanisc, 2015-08-07 18:24:04]

Looks good overall, but I'd prefer to not move field definitions between
entry_kernel.h and syncable_columns.h and introduce an extra dependency on the
header file level.

https://codereview.chromium.org/1258863007/diff/40001/sync/syncable/entry_ker...
File sync/syncable/entry_kernel.h (right):

https://codereview.chromium.org/1258863007/diff/40001/sync/syncable/entry_ker...
sync/syncable/entry_kernel.h:18: #include "sync/syncable/syncable_columns.h"
Instead of including syncable_columns.h in entry_kernel.h, it should be enough
to include in in entry_kernel.cc.

https://codereview.chromium.org/1258863007/diff/40001/sync/syncable/syncable_...
File sync/syncable/syncable_columns.h (right):

https://codereview.chromium.org/1258863007/diff/40001/sync/syncable/syncable_...
sync/syncable/syncable_columns.h:13: enum {
This is an unnecessary change. I'd prefer to keep this in entry_kernel.h

[Gang Wu, 2015-08-07 18:30:09]

Patchset #4 (id:60001) has been deleted

[stanisc, 2015-08-07 19:32:59]

lgtm

[Gang Wu, 2015-08-07 20:50:57]

https://codereview.chromium.org/1258863007/diff/40001/sync/syncable/entry_ker...
File sync/syncable/entry_kernel.h (right):

https://codereview.chromium.org/1258863007/diff/40001/sync/syncable/entry_ker...
sync/syncable/entry_kernel.h:18: #include "sync/syncable/syncable_columns.h"
On 2015/08/07 18:24:04, stanisc wrote:
> Instead of including syncable_columns.h in entry_kernel.h, it should be enough
> to include in in entry_kernel.cc. 

Done.

https://codereview.chromium.org/1258863007/diff/40001/sync/syncable/syncable_...
File sync/syncable/syncable_columns.h (right):

https://codereview.chromium.org/1258863007/diff/40001/sync/syncable/syncable_...
sync/syncable/syncable_columns.h:13: enum {
On 2015/08/07 18:24:04, stanisc wrote:
> This is an unnecessary change. I'd prefer to keep this in entry_kernel.h

Done.

[Gang Wu, 2015-08-07 20:51:29]

The CQ bit was checked by gangwu@chromium.org

[commit-bot: I haz the power, 2015-08-07 20:51:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1258863007/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1258863007/80001

[commit-bot: I haz the power, 2015-08-07 20:58:17]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2015-08-07 20:59:06]

Patchset 4 (id:??) landed as
https://crrev.com/81f85526af97a9e160aa839c9460b535694a0e04
Cr-Commit-Position: refs/heads/master@{#342437}