Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: sync/syncable/directory.cc

Issue 1258863007: [Sync] Add more info for invalid position check (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: move enum back to entry_kernel Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sync/syncable/entry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/syncable/directory.cc
diff --git a/sync/syncable/directory.cc b/sync/syncable/directory.cc
index 720a924e4a6b801a802e55ad825834e7e2509542..1a5faf1f876c4852c53a9ea46a5cd4aef1dd0101 100644
--- a/sync/syncable/directory.cc
+++ b/sync/syncable/directory.cc
@@ -1469,7 +1469,7 @@ void Directory::PutPredecessor(EntryKernel* e, EntryKernel* predecessor) {
// without valid positions. See TODO above.
// Using a release CHECK here because the following UniquePosition::Between
// call crashes anyway when the position string is empty (see crbug/332371).
- CHECK(successor->ref(UNIQUE_POSITION).IsValid());
+ CHECK(successor->ref(UNIQUE_POSITION).IsValid()) << *successor;
// Finally, the normal case: inserting between two elements.
UniquePosition pos = UniquePosition::Between(
« no previous file with comments | « no previous file | sync/syncable/entry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698