Add yet more GN isolates ...

Add yet more GN isolates ...

This should be almost everything left that is currently
running on the Linux GN bot.

- events_unittests
- extensions_browsertests
- extensions_unittests
- gcm_unit_tests
- gfx_unittests
- gpu_unittests
- jingle_unittests
- media_unittests
- mojo_common_unittests
- mojo_public_bindings_unittests
- mojo_public_environment_unittests
- nacl_loader_unittests
- net_unittests
- printing_unittests
- remoting_unittests
- sql_unittests (isolate existed, just swarmed)
- sync_integration_tests
- sync_unit_tests
- unit_tests

There are still more test steps that need isolates that are
not run on the GN bot, most notably browser_tests and interactive_ui_tests
(which is partially done in this CL but doesn't quite work right).

I'll get to those in upcoming CLs.

R=brettw@chromium.org
BUG=504079
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel

Committed: https://crrev.com/f497c796f053e8bb4cdeb541addc811c9a79259b
Cr-Commit-Position: refs/heads/master@{#341392}

[M-A Ruel, 2015-07-26 00:51:24]

maruel@chromium.org changed reviewers:
+ maruel@chromium.org

[M-A Ruel, 2015-07-26 00:51:24]

https://codereview.chromium.org/1258753002/diff/20001/chrome/test/BUILD.gn
File chrome/test/BUILD.gn (right):

https://codereview.chromium.org/1258753002/diff/20001/chrome/test/BUILD.gn#ne...
chrome/test/BUILD.gn:268: "$root_out_dir/locales/en-US.pak",
Why can't you depend on the targets?

https://codereview.chromium.org/1258753002/diff/20001/chrome/test/BUILD.gn#ne...
chrome/test/BUILD.gn:312: data_deps = [
So typos get undetected? :/

https://codereview.chromium.org/1258753002/diff/20001/net/BUILD.gn
File net/BUILD.gn (right):

https://codereview.chromium.org/1258753002/diff/20001/net/BUILD.gn#newcode1368
net/BUILD.gn:1368: "//third_party/pyftpdlib/",
Why are they needed both as data_deps and data?

[Dirk Pranke, 2015-07-26 17:52:53]

https://codereview.chromium.org/1258753002/diff/20001/chrome/test/BUILD.gn
File chrome/test/BUILD.gn (right):

https://codereview.chromium.org/1258753002/diff/20001/chrome/test/BUILD.gn#ne...
chrome/test/BUILD.gn:268: "$root_out_dir/locales/en-US.pak",
On 2015/07/26 00:51:24, M-A Ruel (OOO until Aug 10) wrote:
> Why can't you depend on the targets?

There's a bug in GN where if something is listed as a normal dep
it gets excluded from data_deps. Brett fixed this in

https://codereview.chromium.org/1250883002/

but it hasn't rolled in yet. Once it does, I'll go back and clean these up.

https://codereview.chromium.org/1258753002/diff/20001/chrome/test/BUILD.gn#ne...
chrome/test/BUILD.gn:312: data_deps = [
On 2015/07/26 00:51:24, M-A Ruel (OOO until Aug 10) wrote:
> So typos get undetected? :/

Both variables are currently supported by GN; datadeps was the older one, but
Brett renamed it. We need to go through and rename all of the other uses as
well.

(So datadeps wasn't a typo. typos are detected and produce warnings).

https://codereview.chromium.org/1258753002/diff/20001/net/BUILD.gn
File net/BUILD.gn (right):

https://codereview.chromium.org/1258753002/diff/20001/net/BUILD.gn#newcode1368
net/BUILD.gn:1368: "//third_party/pyftpdlib/",
On 2015/07/26 00:51:24, M-A Ruel (OOO until Aug 10) wrote:
> Why are they needed both as data_deps and data?

same answer.

[M-A Ruel, 2015-07-26 19:39:11]

Cool, lgtm

[Dirk Pranke, 2015-07-28 23:50:05]

Brett, please take a look?

https://codereview.chromium.org/1258753002/diff/60001/net/BUILD.gn
File net/BUILD.gn (right):

https://codereview.chromium.org/1258753002/diff/60001/net/BUILD.gn#newcode1382
net/BUILD.gn:1382: ]
This duplication (and related occurrences elsewhere in the CL)
can be removed now that we've rolled to the latest version of GN,
but I would prefer to do that in a follow-up CL.

[brettw, 2015-07-29 20:01:07]

lgtm

[Dirk Pranke, 2015-07-29 21:29:19]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2015-07-29 21:29:20]

The patchset sent to the CQ was uploaded after l-g-t-m from maruel@chromium.org
Link to the patchset: https://codereview.chromium.org/1258753002/#ps60001
(title: "add sql_unittests to swarming, remove interactive_ui_tests, move mojo
rules")

[commit-bot: I haz the power, 2015-07-29 21:31:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1258753002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1258753002/60001

[commit-bot: I haz the power, 2015-07-29 21:39:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-29 21:39:54]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Dirk Pranke, 2015-07-29 22:36:33]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2015-07-29 22:36:33]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org,
maruel@chromium.org
Link to the patchset: https://codereview.chromium.org/1258753002/#ps80001
(title: "fix variable on mac")

[commit-bot: I haz the power, 2015-07-29 22:37:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1258753002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1258753002/80001

[commit-bot: I haz the power, 2015-07-29 22:42:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-29 22:42:25]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[Dirk Pranke, 2015-07-31 18:33:23]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2015-07-31 18:33:24]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org,
maruel@chromium.org
Link to the patchset: https://codereview.chromium.org/1258753002/#ps100001
(title: "fix net_unittests conditional on android, fix wow_helper dependency on
win")

[commit-bot: I haz the power, 2015-07-31 18:34:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1258753002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1258753002/100001

[commit-bot: I haz the power, 2015-07-31 19:46:34]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-07-31 19:47:29]

Patchset 6 (id:??) landed as
https://crrev.com/f497c796f053e8bb4cdeb541addc811c9a79259b
Cr-Commit-Position: refs/heads/master@{#341392}