Add yet more GN isolates ...

chrome/test/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chrome_build.gni")
 import("//build/config/crypto.gni")
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 import("//chrome/chrome_tests.gni")
 import("//chrome/test/base/js2gtest.gni")
@@ skipping 204 matching lines @@
 if (!is_android) {
   import("//third_party/protobuf/proto_library.gni")
 
   # GYP version: chrome/chrome_tests_unit.gypi:ipc_protobuf_message_test_proto
   proto_library("test_proto") {
     sources = [
       "../common/safe_browsing/ipc_protobuf_message_test.proto",
     ]
   }
 
+  # TODO(GYP): Delete this after we've converted everything to GN.
+  # The _run targets exist only for compatibility w/ GYP.
+  group("interactive_ui_tests_run") {
+    testonly = true
+    deps = [
+      ":interactive_ui_tests",
+    ]
+  }
+
   test("interactive_ui_tests") {
     sources =
         rebase_path(chrome_tests_gypi_values.chrome_interactive_ui_test_sources,
                     ".",
                     "//chrome")
 
+    data = [
+      "//net/data/ssl/certificates/",
+      "//net/tools/testserver/",
+      "//ppapi/tests/test_case.html",
+      "//ppapi/tests/test_case.html.mock-http-headers",
+      "//ppapi/tests/test_page.css",
+      "//ppapi/tests/test_page.css.mock-http-headers",
+      "//third_party/pyftpdlib/",
+      "//third_party/pywebsocket/",
+      "//third_party/tlslite/",
+      "//third_party/zlib/google/test/data/",
+      "//tools/metrics/histograms/histograms.xml",
+      "$root_out_dir/pyproto/google/",
+      "$root_out_dir/resources.pak",
+      "$root_out_dir/ui_test.pak",
+    ]
+    if (is_android || is_linux || is_win) {
+      data += [
+        "$root_out_dir/chrome_100_percent.pak",
+        "$root_out_dir/locales/en-US.pak",
+      ]
+    }
+    if (is_linux) {
+      data += [ "$root_out_dir/libppapi_tests.so" ]
+    }
+    if (is_linux || is_win) {
+      data += [
+        "$root_out_dir/chrome_100_percent.pak",
+        "$root_out_dir/locales/en-US.pak",

[M-A Ruel, 2015/07/26 00:51:24]

Why can't you depend on the targets?

[Dirk Pranke, 2015/07/26 17:52:53]

There's a bug in GN where if something is listed as a normal dep
it gets excluded from data_deps. Brett fixed this in

https://codereview.chromium.org/1250883002/

but it hasn't rolled in yet. Once it does, I'll go back and clean these up.

+        "$root_out_dir/locales/fr.pak",
+      ]
+    }
+
     defines = [ "HAS_OUT_OF_PROC_TEST_RUNNER" ]
     ldflags = []
 
     deps = [
       "//base/allocator",
       "//chrome/browser",
       "//chrome/browser/devtools",
       "//chrome/renderer",
       "//chrome/test:test_support",
       "//chrome:resources",
@@ skipping 19 matching lines @@
       "//ui/resources:ui_test_pak",
       "//ui/web_dialogs:test_support",
     ]
 
     # TODO(rockot) bug 505926: The chrome_extensions_interactive_uitests target
     # should be deleted and this line removed. See the
     # chrome_extensions_interactive_uitests target for more.
     deps += [ "//extensions:chrome_extensions_interactive_uitests" ]
 
     # Runtime dependencies
-    datadeps = [
+    data_deps = [

[M-A Ruel, 2015/07/26 00:51:24]

So typos get undetected? :/

[Dirk Pranke, 2015/07/26 17:52:53]

Both variables are currently supported by GN; datadeps was the older one, but
Brett renamed it. We need to go through and rename all of the other uses as
well.

(So datadeps wasn't a typo. typos are detected and produce warnings).

       "//ppapi:ppapi_tests",
       "//third_party/mesa:osmesa",
     ]
 
     if (toolkit_views) {
       sources += rebase_path(
               chrome_tests_gypi_values.chrome_interactive_ui_test_views_sources,
               ".",
               "//chrome")
       deps += [
@@ skipping 123 matching lines @@
     }
 
     if (cld_version == 0 || cld_version == 2) {
       # Interactive tests should use whatever CLD2 data access mode that the
       # application embedder is using.
       deps += [ "//third_party/cld_2:cld2_platform_impl" ]
     }
 
     if (use_x11) {
       configs += [ "//build/config/linux:xtst" ]
-      datadeps += [ "//tools/xdisplaycheck" ]
+      data_deps += [ "//tools/xdisplaycheck" ]
     }
 
     if (enable_app_list) {
       sources += rebase_path(
               chrome_tests_gypi_values.chrome_interactive_ui_test_app_list_sources,
               ".",
               "//chrome")
     }
 
     if (use_ash) {
@@ skipping 541 matching lines @@
               chrome_tests_gypi_values.chrome_browser_tests_remoting_sources,
               ".",
               "//chrome")
       #deps += [ "//remoting:remoting_webapp" ]  TODO(GYP)
     }
     if (use_x11) {
       deps += [ "//tools/xdisplaycheck" ]
     }
   }
 
+  # TODO(GYP): Delete this after we've converted everything to GN.
+  # The _run targets exist only for compatibility w/ GYP.
+  group("sync_integration_tests_run") {
+    testonly = true
+    deps = [
+      ":sync_integration_tests",
+    ]
+  }
+
   test("sync_integration_tests") {
     sources =
         rebase_path(chrome_tests_gypi_values.sync_integration_tests_sources,
                     ".",
                     "//chrome")
 
+    data = [
+      "//chrome/test/data/sync/",
+      "//net/tools/testserver/",
+      "//sync/tools/testserver/",
+      "//third_party/pyftpdlib/",
+      "//third_party/pywebsocket/",
+      "//third_party/tlslite/",
+      "$root_out_dir/pyproto/",
+      "$root_out_dir/resources.pak",
+    ]
+
+    if (is_linux || is_win) {
+      data += [
+        "$root_out_dir/chrome_100_percent.pak",
+        "$root_out_dir/locales/en-US.pak",
+      ]
+    }
+
     # TODO(phajdan.jr): Only temporary, to make transition easier.
     defines = [ "HAS_OUT_OF_PROC_TEST_RUNNER" ]
 
     deps = [
       ":sync_integration_test_support",
       ":test_support",
       "//base/allocator",
       "//chrome:packed_extra_resources",
       "//chrome:packed_resources",
       "//chrome:resources",
       "//chrome:strings",
       "//chrome/common",
       "//chrome/renderer",
       "//crypto:platform",
       "//sync",
       "//testing/gmock",
       "//testing/gtest",
       "//third_party/icu",
       "//third_party/leveldatabase",
       "//third_party/WebKit/public:blink",
     ]
 
+    data_deps = [ "//third_party/mesa:osmesa" ]
+
     if (cld_version == 0 || cld_version == 2) {
       # Language detection is irrelevant to sync, so it can depend on any
       # implementation for CLD2. Dynamic is smaller, so go with dynamic.
       deps += [ "//third_party/cld_2:cld2_dynamic" ]
     }
     if (is_mac) {
       # Dictionary sync is disabled on Mac.
       sources -= [
         "../browser/sync/test/integration/multiple_client_dictionary_sync_test.cc",
         "../browser/sync/test/integration/single_client_dictionary_sync_test.cc",
@@ skipping 127 matching lines @@
               chrome_tests_unit_gypi_values.chrome_unit_tests_chromeos_gtestjs_sources,
               ".",
               "//chrome")
       extra_js_files += rebase_path(
               chrome_tests_unit_gypi_values.chrome_unit_tests_chromeos_js_sources,
               ".",
               "//chrome")
     }
   }
 
+  # TODO(GYP): Delete this after we've converted everything to GN.
+  # The _run targets exist only for compatibility w/ GYP.
+  group("unit_tests_run") {
+    testonly = true
+    deps = [
+      ":unit_tests",
+    ]
+  }
+
   test("unit_tests") {
     sources =
         rebase_path(chrome_tests_unit_gypi_values.chrome_unit_tests_sources,
                     ".",
                     "//chrome")
 
+    data = [
+      "data/",
+      "//base/test/data/",
+      "//chrome/third_party/mock4js/",
+      "//components/test/data/",
+      "//extensions/test/data/",
+      "//google_apis/test/data/",
+      "//net/data/",
+      "//net/tools/testserver/",
+      "//third_party/accessibility-audit/axs_testing.js",
+      "//third_party/hunspell_dictionaries/",
+      "//third_party/pyftpdlib/",
+      "//third_party/pywebsocket/",
+      "//third_party/tlslite/",
+      "//third_party/zlib/google/test/data/",
+      "//tools/metrics/histograms/histograms.xml",
+      "$root_out_dir/pyproto/google/",
+      "$root_out_dir/test_data/chrome/browser/resources/google_now/",
+      "$root_out_dir/test_data/chrome/browser/resources/print_preview/",
+      "$root_out_dir/test_data/chrome/renderer/resources/extensions/",
+      "$root_out_dir/test_data/ui/webui/",
+      "$root_out_dir/resources.pak",
+    ]
+    if (is_android || is_linux || is_win) {
+      data += [
+        "$root_out_dir/chrome_100_percent.pak",
+        "$root_out_dir/locales/en-US.pak",
+      ]
+    }
+
     defines = []
 
     deps = [
       # NOTE: New depndencies should generally be added in the OS!="ios"
       # dependencies block below, rather than here.
       # Unit tests should only depend on:
       # 1) everything that the chrome binaries depend on:
       "//chrome:browser_dependencies",
       "//chrome:child_dependencies",
 
@@ skipping 604 matching lines @@
     "//third_party/mojo/src/mojo/edk/system",
   ]
 
   if (!is_android && use_ash) {
     sources += rebase_path(
             chrome_tests_unit_gypi_values.chrome_test_support_unit_ash_sources,
             ".",
             "//chrome")
   }
 }