Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1009)

Issue 1258733003: Expose glResizeCHROMIUM() and remove some uses of MojoGLES2GetGLES2Interface(). (Closed)

Created:
5 years, 5 months ago by viettrungluu
Modified:
5 years, 4 months ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Expose glResizeCHROMIUM() and remove some uses of MojoGLES2GetGLES2Interface(). * Add thunks, etc. for glResizeCHROMIUM(). * In the places where the GLES2Interface::ResizeCHROMIUM() was converted to glResizeCHROMIUM(), the context better already be current. I think this is generally implied by the rest of the code. R=jamesr@chromium.org BUG=#337, fixes #338 Committed: https://chromium.googlesource.com/external/mojo/+/a65790afc19081ef42fba2dc69478705b73629ea

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -24 lines) Patch
M examples/spinning_cube/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M examples/spinning_cube/gles2_client_impl.cc View 1 2 chunks +6 lines, -5 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 2 chunks +4 lines, -1 line 0 comments Download
M mojo/gles2/gles2_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/public/c/gles2/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
A + mojo/public/c/gles2/chromium_resize.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/public/c/gles2/gles2_call_visitor_chromium_resize_autogen.h View 1 chunk +4 lines, -2 lines 0 comments Download
M mojo/public/platform/native/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A mojo/public/platform/native/gles2_impl_chromium_resize_thunks.h View 1 chunk +44 lines, -0 lines 0 comments Download
A mojo/public/platform/native/gles2_impl_chromium_resize_thunks.cc View 1 chunk +31 lines, -0 lines 0 comments Download
M services/js/modules/gl/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M services/js/modules/gl/context.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M shell/native_application_support.cc View 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
5 years, 5 months ago (2015-07-24 22:33:15 UTC) #1
jamesr
lgtm https://codereview.chromium.org/1258733003/diff/1/examples/spinning_cube/gles2_client_impl.cc File examples/spinning_cube/gles2_client_impl.cc (right): https://codereview.chromium.org/1258733003/diff/1/examples/spinning_cube/gles2_client_impl.cc#newcode55 examples/spinning_cube/gles2_client_impl.cc:55: glResizeCHROMIUM(size_.width, size_.height, 1); i think the last parameter ...
5 years, 4 months ago (2015-07-27 23:16:44 UTC) #2
viettrungluu
https://codereview.chromium.org/1258733003/diff/1/examples/spinning_cube/gles2_client_impl.cc File examples/spinning_cube/gles2_client_impl.cc (right): https://codereview.chromium.org/1258733003/diff/1/examples/spinning_cube/gles2_client_impl.cc#newcode55 examples/spinning_cube/gles2_client_impl.cc:55: glResizeCHROMIUM(size_.width, size_.height, 1); On 2015/07/27 23:16:44, jamesr wrote: > ...
5 years, 4 months ago (2015-07-28 16:49:43 UTC) #3
viettrungluu
5 years, 4 months ago (2015-07-28 16:49:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a65790afc19081ef42fba2dc69478705b73629ea (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698