Expose glResizeCHROMIUM() and remove some uses of MojoGLES2GetGLES2Interface().

examples/spinning_cube/gles2_client_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#ifndef GL_GLEXT_PROTOTYPES
+#define GL_GLEXT_PROTOTYPES
+#endif
+
 #include "examples/spinning_cube/gles2_client_impl.h"
 
 #include <GLES2/gl2.h>
 #include <GLES2/gl2ext.h>
+#include <GLES2/gl2extchromium.h>
 #include <math.h>
 #include <stdlib.h>
 
-#include "gpu/command_buffer/client/gles2_interface.h"
 #include "mojo/public/c/gles2/gles2.h"
 #include "mojo/public/cpp/environment/environment.h"
 #include "mojo/public/cpp/utility/run_loop.h"
 
 namespace examples {
 namespace {
 
 float CalculateDragDistance(const mojo::PointF& start,
                             const mojo::PointF& end) {
   return hypot(start.x - end.x, start.y - end.y);
@@ skipping 18 matching lines @@
 
 GLES2ClientImpl::~GLES2ClientImpl() {
   MojoGLES2DestroyContext(context_);
 }
 
 void GLES2ClientImpl::SetSize(const mojo::Size& size) {
   size_ = size;
   cube_.set_size(size_.width, size_.height);
   if (size_.width == 0 || size_.height == 0 || !context_)
     return;
-  static_cast<gpu::gles2::GLES2Interface*>(
-      MojoGLES2GetGLES2Interface(context_))->ResizeCHROMIUM(size_.width,
-                                                            size_.height,
-                                                            1);
+  glResizeCHROMIUM(size_.width, size_.height, 1);

[jamesr, 2015/07/27 23:16:44]

i think the last parameter is a float, so you should write 1.f (i.e. the old
code was busted)

the reason for the glResizeCHROMIUM extension existing was to support handling
deviceScaleFactor changes in a natural way (i.e. scale content), but in Mojo the
graphics system is all in physical pixels (no implicit scaling) and surfaces are
not resizeable so this isn't really needed. we should probably instead provide
an explicit resize entry point to specify the onscreen context's width/height. 
This has to be in order with GL commands.  The easiest way to ensure ordering is
to put it in the command stream itself (like this) but we could also make it a
mojom entry point and require that the user flush before the call.

[viettrungluu, 2015/07/28 16:49:42]

Done (good to be explicit I guess, even if int -> float conversions are
automatic).

   WantToDraw();
 }
 
 void GLES2ClientImpl::HandleInputEvent(const mojo::Event& event) {
   switch (event.action) {
     case mojo::EVENT_TYPE_POINTER_DOWN:
       if (event.flags & mojo::EVENT_FLAGS_RIGHT_MOUSE_BUTTON)
         break;
       capture_point_.x = event.pointer_data->x;
       capture_point_.y = event.pointer_data->y;
@@ skipping 80 matching lines @@
   float delta = static_cast<float>(offset) / 1000000.;
   last_time_ = now;
   cube_.UpdateForTimeDelta(delta);
   cube_.Draw();
 
   MojoGLES2SwapBuffers();
   WantToDraw();
 }
 
 }  // namespace examples